Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 56506 - ATerm crashes with large saveLines resource value (under Fluxbox, X.Org?)
Summary: ATerm crashes with large saveLines resource value (under Fluxbox, X.Org?)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High critical (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-08 19:20 UTC by Merlyn Morgan-Graham
Modified: 2004-07-12 11:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Merlyn Morgan-Graham 2004-07-08 19:20:14 UTC
ATerm crashes on my system when I specify a large value in ~/.Xdefaults for XTerm*saveLines.  Particularly in range between 327xx, crashing sooner the closer I get to 32767.

The maximum value isn't specified in the man page, but I figured out it's probably 32767, since any number higher than that will knock down the buffer to the default length.

The error message I get in ~/.xsession-errors is:
aterm: screen.c:872: scr_add_lines: Assertion `screen.cur.row >= -TermWin.nscrolled' failed.

Reproducible: Always
Steps to Reproduce:
1. Modify ~/.Xdefaults to add the line XTerm*saveLines:32767
2. run "xrdb -merge ~/.Xdefaults"
3. launch a new aterm window
4. "cd /" "ls -laR"
Actual Results:  
Part way through the directory listing, the window disappeared, and the error
was logged to ~/.xsession-errors:

aterm: screen.c:872: scr_add_lines: Assertion `screen.cur.row >=
-TermWin.nscrolled' failed.

Expected Results:  
The software should not have failed it's assertion.

The version of ATerm I am using is 0.4.2-r9, use flag is -cjk
I am running under fluxbox version 0.9.9, use flags are -gnome -kde +nls
+truetype -xinerama
The XServer I have is xorg-x11-6.7.0-r1, use flags are -3dfx -3dnow -cjk -debug
+doc -hardened -ipv6 +mmx +nls +pam -pie -sdk +sse -static

I am running ATerm with the following options specified in my ~/.Xdefaults file:
XTerm*loginShell:true
XTerm*background:Black
XTerm*foreground:White
XTerm*saveLines:32767
XTerm*visualBell:true
aterm*transparent:true
aterm*transpscrollbar:true
aterm*tinting:red
aterm*shading:50

Compiler flags are:
CFLAGS="-O3 -march=pentium4 -funroll-loops -fprefetch-loop-arrays -pipe"
Comment 1 Octavio Ruiz (Ta^3) 2004-07-08 21:09:07 UTC
No problem here.

XFCE4+Aterm

Aterm*saveLines:      32768

x11-terms/aterm-0.4.2-r9  -cjk
x11-base/xorg-x11-6.7.0-r1  -3dfx -3dnow -cjk -debug -doc -hardened +ipv6 +mmx +nls +pam -pie -sdk +sse -static

Can any body else reproduce the bug?
Comment 2 Merlyn Morgan-Graham 2004-07-08 22:36:12 UTC
32768, at least in my tests here, will roll the saveLines value back over to the default.  It seems the maximum accepted value is 32767, therefore a value of 32768 would make a _much_ smaller buffer, i.e. on mine 88 lines.  It seems to crash faster the closer it gets to 32767, but crashes on smaller values as well.  The default value of 88 lines probably wouldn't make it crash, or at least not in any reasonable ammount of time.
Comment 3 Michal Januszewski (RETIRED) gentoo-dev 2004-07-12 06:31:53 UTC
Fixed in -r10. I've also extended the saveLines range to 0-65535, hopefully not breaking anything else in the process ;)
Comment 4 Merlyn Morgan-Graham 2004-07-12 11:06:32 UTC
Updated to version -r10.  Aterm no longer crashes on my system with a saveLines value of 32767, nor does it crash with a value of 65535.  Great work! =)