564950 – media-sound/lmms-1.1.3 - fails to build with gcc 5

Bug 564950 - media-sound/lmms-1.1.3 - fails to build with gcc 5

Summary: media-sound/lmms-1.1.3 - fails to build with gcc 5

Status:	RESOLVED UPSTREAM

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Linux bug wranglers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-11-05 17:05 UTC by Jonas Jelten
Modified:	2015-11-05 19:14 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
fix the warning (lmms-comparison.patch,975 bytes, patch) 2015-11-05 17:05 UTC, Jonas Jelten	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonas Jelten 2015-11-05 17:05:00 UTC

Build fails due to a Werror, werror should never be used in distributed packages...

I'm using gcc-5.2.

/tmp/portage/media-sound/lmms-1.1.3/work/lmms-1.1.3/src/core/AutomatableModel.cpp: In member function ‘void AutomatableModel::setAutomatedValue(float)’:
/tmp/portage/media-sound/lmms-1.1.3/work/lmms-1.1.3/src/core/AutomatableModel.cpp:315:36: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
     !(*it)->fittedValue( m_value ) !=
                                    ^
cc1plus: all warnings being treated as errors


Patch is attached.

Reproducible: Always

Comment 1 Jonas Jelten 2015-11-05 17:05:57 UTC

Created attachment 416118 [details, diff]
fix the warning

Comment 2 Jonas Jelten 2015-11-05 17:08:25 UTC

Patch source (in case you wonder why the ! was just removed :)

https://github.com/LMMS/lmms/issues/1761

Comment 3 Tomáš Mózes 2015-11-05 19:14:11 UTC

Try to poke the maintainer of lmms to release a new version @github.