56472 – phpsysinfo ebuild calls kernel-mod_getversion three times

Bug 56472 - phpsysinfo ebuild calls kernel-mod_getversion three times

Summary: phpsysinfo ebuild calls kernel-mod_getversion three times

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High trivial (vote)
Assignee:	PHP Bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-07-08 10:38 UTC by James Slater
Modified:	2005-04-01 09:11 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Uses kernel-mod_getversion directly (phpsysinfo-2.1-r3.patch,725 bytes, patch) 2004-07-08 10:39 UTC, James Slater	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James Slater 2004-07-08 10:38:18 UTC

phpsysinfo-2.1-r2.ebuild needs to check the current kernel version. At the moment it does:

kernel-mod_is_2_4_kernel
kernel-mod_is_2_5_kernel
kernel-mod_is_2_6_kernel

Which is a bit wasteful as each of those calls kernel-mod_getversion and produces the same output on the screen three times over. So ... fix kernel-mod-getversion to cache consecutive queries? Ignore it as phpsysinfo-2.2 looks like it might not need it, or fix it as in the attached patch?

Any comments would be welcome. :-)

Reproducible: Always
Steps to Reproduce:
1. emerge phpsysinfo-2.1-r2
2. Watch for repeated 'Building for Linux 2.x.x found in /usr/src/linux' lines

Comment 1 James Slater 2004-07-08 10:39:49 UTC

Created attachment 35018 [details, diff]
Uses kernel-mod_getversion directly

Comment 2 Robin Johnson archtester

2005-03-08 17:34:44 UTC

stuart: this should cease to be a problem when you fix the kernel stuff in phpsysinfo as you are doing.

Comment 3 Markus Rothe (RETIRED) gentoo-dev

2005-04-01 09:11:40 UTC

latest ebuild no longer uses this functions.