Only worth mentioning: SRC_URI has changed. Live ebuild patch has been reworked. Reproducible: Always
Created attachment 415824 [details] new ebuild file
Created attachment 415826 [details] reworked patch
Sven, Can you commit eid-mw-4.1.9.ebuild and files/gtk_not_required_9999.patch in attachments. You can also remove eid-mw-4.0.*.ebuild Feel free to email me if you have any questions.
finally; he patch appears to have been innocently named gtk_not_required_9999.patch in Ceomment 3 but gtk_not_required_4.1.4.patch in ebuild. I settled on the former. This caused confusion. IUSE="+gtk +xpi +dialogs" To have the patch run it requires app-crypt/eid-mw $ USE="-dialogs -gtk" ebuild eid-mw-9999.ebuild clean prepare which yields Switched to a new branch 'branch-master' >>> Unpacked to /mnt/gen2/TmpDir/portage/app-crypt/eid-mw-9999/work/eid-mw-9999 >>> Source unpacked in /mnt/gen2/TmpDir/portage/app-crypt/eid-mw-9999/work >>> Preparing source in /mnt/gen2/TmpDir/portage/app-crypt/eid-mw-9999/work/eid-mw-9999 ... * Applying gtk_not_required_4.1.4.patch ... [ ok ] so the patch takes. --------------------------------------------------------------- ../gentoo/app-crypt/eid-mw $ USE="-dialogs -gtk" ebuild eid-mw-9999.ebuild clean install yields >>> Completed installing eid-mw-9999 into /mnt/gen2/TmpDir/portage/app-crypt/eid-mw-9999/image/ strip: x86_64-pc-linux-gnu-strip --strip-unneeded -R .comment -R .GCC.command.line -R .note.gnu.gold-version usr/lib64/libbeidpkcs11.so.0.0.0 so it is effective. I am still curious about applying patches in live ebuilds. So in light of it being addressed to one dev only, and the above: commit c9f8233ca2c5732c6a95b44e7b1c34ad30426f79 Author: Ian Delaney <idella4@gentoo.org> Date: Sun Nov 8 15:38:05 2015 +0800 app-crypt/eid-mw: add gtk_not_required_4.1.4.patch addressing issue in gentoo bug Submitted by proxy maintainer via the gentoo bug Gentoo bug: #564582 I set this to TEST-REQUEST
(In reply to Ian Delaney from comment #4) Sorry if I mixed two things in the same bug : Old gtk_not_required_4.1.4 patch has to work with both eid-mw-4.1.4 and eid-mw-4.1.9. Current live ebuild does not work anymore with current gtk_not_required_9999 patch. That is why I have attached a reworked patch for live ebuild, so that Sven can commit everything at once.
Well I committed it as best I made it out and left it set test request in case something isn't correct. Leaving it that way.
Well this is what I meant by confusion. It seems I have added this to the live ebuild, as to how that happened I cannot possibly remember. I do know it stems from the gtk_not_required_9999.patch bs.gtk_not_required_4.1.4.patch. from repoman full DESCRIPTION.toolong 5 app-crypt/eid-mw/eid-mw-4.0.6_p1480.ebuild: DESCRIPTION is 86 characters (max 80) app-crypt/eid-mw/eid-mw-4.0.6_p1620.ebuild: DESCRIPTION is 86 characters (max 80) app-crypt/eid-mw/eid-mw-4.1.4.ebuild: DESCRIPTION is 86 characters (max 80) app-crypt/eid-mw/eid-mw-4.1.9.ebuild: DESCRIPTION is 86 characters (max 80) app-crypt/eid-mw/eid-mw-9999.ebuild: DESCRIPTION is 86 characters (max 80) ebuild.notadded 1 DESCRIPTION reduced accordingly. commit 729b379693223cbb8a3c94b2932fdc209000ee04 Author: Ian Delaney <idella4@gentoo.org> Date: Thu Nov 12 01:04:31 2015 +0800 app-crypt/eid-mw: bump to 4.1.9 wrt the gentoo bug, missed in previous commit Also Reduced DESCRIPTION to < 80 chars fixing the QA violation in only recent two versions. ebuild by proxy maintainer via the gentoo bug Gentoo bug: #564582 ----------------------------------------------------- Sorry for the mixup
Created attachment 416796 [details] Good patch for versions 4.1.4 and 4.1.9
(In reply to Ian Delaney from comment #7) let's summarize... First attachment (new ebuild file) : comitted OK Second attachment (reworked patch) : not committed yet. This is the right patch for live ebuild. Third attachment (Good patch for versions 4.1.4 and 4.1.9) : this is the right patch. Can you commit it. > from repoman full > > DESCRIPTION.toolong 5 > app-crypt/eid-mw/eid-mw-4.0.6_p1480.ebuild: DESCRIPTION is 86 characters > (max 80) > app-crypt/eid-mw/eid-mw-4.0.6_p1620.ebuild: DESCRIPTION is 86 characters > (max 80) > app-crypt/eid-mw/eid-mw-4.1.4.ebuild: DESCRIPTION is 86 characters (max > 80) > app-crypt/eid-mw/eid-mw-4.1.9.ebuild: DESCRIPTION is 86 characters (max > 80) > app-crypt/eid-mw/eid-mw-9999.ebuild: DESCRIPTION is 86 characters (max 80) > ebuild.notadded 1 > Can you change DESCRIPTION : Old : "Belgian Electronic Identity Card middleware supplied by the Belgian Federal Government". New: "Electronic Identity Card middleware supplied by the Belgian Federal Government". > Sorry for the mixup You're welcome.
commit 7f9ea004e09fbf082532931934f87a6e8e0493bf Author: Ian Delaney <idella4@gentoo.org> Date: Sat Nov 14 22:58:33 2015 +0800 app-crypt/eid-mw: revise and correct patches Patches apply to versions 4.1.4, 4.1.9 and the live ebuild, supplied by proxy maintainer sourced from the gentoo bug Gentoo bug: #564582
