Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 564564 - www-servers/nginx: add nginx-ldap-auth to nginx
Summary: www-servers/nginx: add nginx-ldap-auth to nginx
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Tiziano Müller (RETIRED)
URL: https://github.com/kvspb/nginx-auth-ldap
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-31 13:02 UTC by Vladimir Datsevich
Modified: 2016-02-06 13:59 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ldap.diff (ldap.diff,2.47 KB, patch)
2016-01-14 10:34 UTC, Tony Vroon (RETIRED)
Details | Diff
ldap2.diff (ldap2.diff,2.50 KB, patch)
2016-01-14 11:09 UTC, Tony Vroon (RETIRED)
Details | Diff
ldap3.diff (ldap3.diff,3.00 KB, patch)
2016-01-14 13:49 UTC, Tony Vroon (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Datsevich 2015-10-31 13:02:40 UTC
nginx-auth-ldap is missing.

Could you please add it to the ebuild?

[1] https://github.com/nginxinc/nginx-ldap-auth
[2] https://www.nginx.com/blog/nginx-plus-authenticate-users/

Thank you in advance.

Reproducible: Always

Actual Results:  
Module not available at the moment -> no auth against LDAP possible.

Expected Results:  
Module available -> auth against LDAP is possible :)
Comment 1 Tony Vroon (RETIRED) gentoo-dev 2015-12-16 15:13:42 UTC
Seeking permission to commit. Unable to raise maintainer on IRC.
Comment 2 Manuel Rüger (RETIRED) gentoo-dev 2015-12-16 19:21:17 UTC
Could you provide a tested patch and attach it, so we could review it here?

The maintainer jbergstroem is usally available in #gentoo-python
Comment 3 Johan Bergström 2015-12-16 20:30:32 UTC
Yo, happy to review/test but won't do this myself since I have no need for it.
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2016-01-06 08:35:53 UTC
Submitted upstream bug:
https://github.com/nginxinc/nginx-ldap-auth/issues/3
Comment 5 Tony Vroon (RETIRED) gentoo-dev 2016-01-14 10:34:38 UTC
Created attachment 422868 [details, diff]
ldap.diff

Upstream has now released a versioned tarball. I still need to actually install files (no C code to compile, just python), but can you confirm that I have picked the correct module category, naming scheme etc?
Comment 6 Tony Vroon (RETIRED) gentoo-dev 2016-01-14 11:09:36 UTC
Created attachment 422872 [details, diff]
ldap2.diff

Let's go with the C version instead, this Python mess is doing my head in. Is this okay for both 1.9.7-r1 & 1.8.0-r1 please?
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2016-01-14 11:45:12 UTC
To confirm, I've asked for an updated release:
https://github.com/kvspb/nginx-auth-ldap/issues/114
Comment 8 Tony Vroon (RETIRED) gentoo-dev 2016-01-14 13:49:47 UTC
Created attachment 422888 [details, diff]
ldap3.diff

Updating CDEPEND based on review comments by Tiziano "dev-zero" Müller on #gentoo-python.
Comment 9 Johan Bergström 2016-01-22 10:43:31 UTC
Tony: I don't think we should touch the LTS (1.8.x) series in terms of modules. We did that for 1.6/1.7 and it bit us pretty hard. Lets use stable series (currently 1.9) to add and bump modules and keep bugfixes to lts ones. Thoughts?
Comment 10 Johan Bergström 2016-01-22 13:23:56 UTC
Also,
instead of waiting for a version; lets pin it to the last commit and hope he doesn't force pushes at commit or older.
Comment 11 Manuel Rüger (RETIRED) gentoo-dev 2016-02-06 13:59:13 UTC
commit 2499a68efa4f3b685de907ed6e1e17afb408058f
Author: Johan Bergström <bugs@bergstroem.nu>
Date:   Wed Feb 3 23:08:05 2016 +0100

    www-servers/nginx: Add auth_ldap, stream, slice modules
    
    This commit adds http_slice, stream, auth_ldap modules and support for
    libressl. It also updates 3rd party modules, enables http2 by default
    and disables gzip by default.


Fixed in 1.9.10-r1