Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 564194 - net-analyzer/ndoutils-2.0.0 - install is made for Nagios 4.x by default
Summary: net-analyzer/ndoutils-2.0.0 - install is made for Nagios 4.x by default
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2015-10-26 16:54 UTC by Bertrand Jacquin
Modified: 2017-07-23 14:02 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bertrand Jacquin 2015-10-26 16:54:12 UTC
net-analyzer/ndoutils src_install use default function that use install-4x

src/Makefile:

install: install-4x
        $(INSTALL) -m 774 $(INSTALL_OPTS) file2sock $(DESTDIR)$(BINDIR)
        $(INSTALL) -m 774 $(INSTALL_OPTS) log2ndo $(DESTDIR)$(BINDIR)
        $(INSTALL) -m 774 $(INSTALL_OPTS) sockdebug $(DESTDIR)$(BINDIR)

This is that if net-analyzer/nagios-core-3.5.1 is installed, then broker stops to work and give the following error:

  Error: Could not load module '/usr/bin/ndomod.o' -> file not found

Install log:

>>> Install ndoutils-2.0.0 into /var/tmp/portage/net-analyzer/ndoutils-2.0.0/image/ category net-analyzer
make -j4 DESTDIR=/var/tmp/portage/net-analyzer/ndoutils-2.0.0/image/ install 
cd ./src && make install
make[1]: Entering directory '/var/tmp/portage/net-analyzer/ndoutils-2.0.0/work/ndoutils-2.0.0/src'
/usr/lib/portage/python2.7/ebuild-helpers/xattr/install -c -m 775 -o nagios -g nagios -d /var/tmp/portage/net-analyzer/ndoutils-2.0.0/image//usr/bin
/usr/lib/portage/python2.7/ebuild-helpers/xattr/install -c -m 755 -o nagios -g nagios ndo2db-4x /var/tmp/portage/net-analyzer/ndoutils-2.0.0/image//usr/bin/ndo
2db
/usr/lib/portage/python2.7/ebuild-helpers/xattr/install -c -m 755 -o nagios -g nagios ndomod-4x.o /var/tmp/portage/net-analyzer/ndoutils-2.0.0/image//usr/bin/n
domod.o
/usr/lib/portage/python2.7/ebuild-helpers/xattr/install -c -m 774 -o nagios -g nagios file2sock /var/tmp/portage/net-analyzer/ndoutils-2.0.0/image//usr/bin
/usr/lib/portage/python2.7/ebuild-helpers/xattr/install -c -m 774 -o nagios -g nagios log2ndo /var/tmp/portage/net-analyzer/ndoutils-2.0.0/image//usr/bin
/usr/lib/portage/python2.7/ebuild-helpers/xattr/install -c -m 774 -o nagios -g nagios sockdebug /var/tmp/portage/net-analyzer/ndoutils-2.0.0/image//usr/bin

  Hint: NDOUtils Installation against Nagios v4.x
  completed.

  If you want to install NDOUtils for Nagios v3.x
  please type  'make install-3x

  If you want to install NDOUtils for Nagios v2.x
  please type  'make install-2x


  Next step should be the database initialization/upgrade
  cd into the db/ directory and either:
     ./installdb  (for a new installation) or:
     ./upgradedb  (for an existing one)

make[1]: Leaving directory '/var/tmp/portage/net-analyzer/ndoutils-2.0.0/work/ndoutils-2.0.0/src'

Here is a patch to avoid such issue.

Reproducible: Always
Comment 1 Bertrand Jacquin 2015-10-26 17:06:21 UTC
PR proposal: https://github.com/gentoo/gentoo/pull/294
Comment 2 Patrice Clement gentoo-dev 2015-11-17 13:53:21 UTC
commit 91b4fda (HEAD, master)
Merge: 2501cdd ff72e26
Author: Patrice Clement <monsieurp@gentoo.org>
Date:   Tue Nov 17 13:49:42 2015 +0000

    Merge remote-tracking branch 'github/pr/294'. Fixes bug 564194.

Maintainer timeout. PR looks good, has been reviewed by mgorny and has been merged by myself.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2015-11-18 04:59:25 UTC
(In reply to Patrice Clement from comment #2)
> commit 91b4fda (HEAD, master)
> Merge: 2501cdd ff72e26
> Author: Patrice Clement <monsieurp@gentoo.org>
> Date:   Tue Nov 17 13:49:42 2015 +0000
> 
>     Merge remote-tracking branch 'github/pr/294'. Fixes bug 564194.
> 
> Maintainer timeout. PR looks good, has been reviewed by mgorny and has been
> merged by myself.

What is a maintainer timeout? This bug report was assigned on the 26th and it's now the 18th of the next month. Meanwhile no progress showed on the bug report.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2015-11-18 05:02:48 UTC
And now we have a single ebuild (no revision bump) that automagically picks a nagios version at compile time and never looks back (not even after a nagios upgrade).
Comment 5 Michael Orlitzky gentoo-dev 2017-07-23 14:02:57 UTC
I realize I'm not the maintainer of record on ndoutils, but I am preparing a version bump for it, and I maintain nagios itself. The 3.x series of nagios has outstanding security bugs that won't be fixed, and I'm going to get rid of it ASAP. As a result, the next version of ndoutils is going to target nagios-4.x exclusively, because that's all that we'll have in the tree.

I have three pull requests headed upstream for ndoutils, and once they're ACKed, I'll commit the new ndoutils ebuild.