Created attachment 415530 [details] Based on ebuild by Bertrand Jacquin <bertrand@jacquin.bzh> Hi! Please find attached qtpass-1.0.3.ebuild QtPass is a multi-platform GUI for app-admin/pass, the standard unix password manager. It can either use pass or gpg directly. I suggest pp-admin/qtpasspass Also, this ebuild depends on dev-qt/qtcore:5 dev-qt/qtgui:5[xcb] dev-qt/qtwidgets:5 dev-qt/qtnetwork:5 app-crypt/gnupg optionally app-admin/pass Thanks in advance, Anne Jan Brouwer
The suggested location was miss-pasted . . should be: app-admin/qtpass
I am happy to step as maintainer for the package, but I will need a proxy maintainer, I think?
Created attachment 417794 [details] qtpass-1.0.5.ebuild From version 1.0.5 up QtPass needs linguist-tools as build-dependency. Cleaned up the ebuild a bit, added more (compatible) platforms. I have tested this ebuild on a clean VM image: https://pad.ijhack.nl/p/qtpass-gentoo-test
(In reply to Merlijn Wajer from comment #2) > I am happy to step as maintainer for the package, but I will need a proxy > maintainer, I think? Proxy Maintainers project can help with that: https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
To Anne Jan Brouwer and Merlijn Wajer: 1. There is much white space present in the submitted ebuild, mostly the indents need be tab spaces. from dev-qt/qtgui:5[xcb] to app-admin/pass, by convention, either 1 or 2 tab spaces are correct. 2. KEYWORD arm is absent in the critical dep package app-admin/pass 3. INSTALL_ROOT="${ED}" caters to a prefix install and no prefix KEYWORDS are present in this ebuild's KEYWORDS. ${ED} will work for both but the correct for a regulat host system is "${D}". Once all deps emerged, >>> Completed installing qtpass-1.0.5 into /mnt/gen2/TmpDir/portage/app-admin/qtpass-1.0.5/image/ At this point I don't know whether to expect Anne Jan Brouwer or Merlijn Wajer to edit and re-submit.
With regards to 2: I can test the ebuild on my ARM laptop. With regards to 1 and 3, I will poke Anne Jan Brouwer and one of us will surely come back with a fixed ebuild. Thanks.
Created attachment 419890 [details] qtpass-1.0.5.ebuild_ My version of ebuild: 1. No need to explicitly inherit eutils, qmake-utils do this for us. 2. Support of qt4 and qt5. (Tested). 3. No arm in keywords, and I don't see that app-admin/pass supports it. 4. Patch to fix segfault (https://github.com/IJHack/qtpass/issues/122) 5. epatch_user. Tested on x86 and amd64. repoman -d full RepoMan scours the neighborhood... RepoMan sez: "If everyone were like you, I'd be out of business!"
Created attachment 419892 [details] metadata for qtpass-1.0.5.ebuild
(In reply to SpiderX from comment #8) > Created attachment 419892 [details] > metadata for qtpass-1.0.5.ebuild would you care to be set as a proxy maintainer of this package under the supervision / support of the proxy maintainers project?
> would you care to be set as a proxy maintainer of this package under the supervision / support of the proxy maintainers project? Sure. I agree.
Runtest of the ebuild in attachment 419890 [details] works fine for me with both USE=qt5 and USE=-qt5.
I shall get onto reviewing and runtesting the ebuild next thing. Let's see if we can get a criss tester.
I have added the package based on the ebuild submitted in https://bugs.gentoo.org/attachment.cgi?id=419892 Minor touch which I decided were not worthy of delaying its addition I simply outline here. You can peruse them at leisure. They are points of style and syntax which in the scheme of bash programming are trivalitites; 1. DESCRIPTION too long. Need be <= 80 chars. There is a rule to NOT include the name of the package within the Description, so cutting QtPass is a + the period at the ned cuts it down to size. 2. I could have expanded on IUSE="+qt5" as a default choice but it will siffice 3. The sed statements in src_prepare() were a country mile long. I merely lime split them to keep them <= 80 chars. The msg in the first I could have cut since generally a sed statement generally do not warrant a msg. It doesn't hurt. 4. ditto the Comment of the 2nd. sed statement. 5. White space issues in metadata and substituted the line of <description> with that in the sample page of https://wiki.gentoo.org/wiki/Project:Proxy_Maintainer commit 1b3be9434b4ae36e1a80319453666fd5e21dacb1 Author: Ian Delaney <idella4@gentoo.org> Date: Mon Jan 4 15:13:14 2016 +0800 app-admin/qtpass: New ebuild, a GUI for app-admin/pass in qt ebuild submitted by the OP Anne Jan Brouwer which was edited by Merlijn Wajer who agreed to proxy maintain, however in the end, ebuild also submitted by spiderx who also agreed to proxy maintain. With consent by Merlijn Wajer, the proxy maintainership has been assigned to spiderx; ebuild submitted in Comment 8 of the gentoo bug and usedfor this addition to the tree with minor touchups to bring style and syntax in the ebuild and metadata to required needs. Cross tested fully by user wraeth and myself. Fixes and closes the gentoo bug Gentoo bug: #564190
