56394 – (PATCH)gaim-0.79-r1 crashes when connecting

Bug 56394 - (PATCH)gaim-0.79-r1 crashes when connecting

Summary: (PATCH)gaim-0.79-r1 crashes when connecting

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All All

Importance:	High critical
Assignee:	Gaim Bugs Crew

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2004-07-07 16:29 UTC by devsk
Modified:	2004-07-07 20:24 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
check string before writing to a file (gaim-0.79-solaris-libc.patch,480 bytes, patch) 2004-07-07 16:30 UTC, devsk	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description devsk 2004-07-07 16:29:34 UTC

The solaris libc string functions crash if the string passed is null. gaim code should check if the string is null before calling strlen on it for example.

Reproducible: Always
Steps to Reproduce:
1. emerge gaim
2. gaim
3. crash in fprintf to a file while saving the accounts.xm.


Actual Results:  
crash

Expected Results:  
shoudn't crash

Comment 1 devsk 2004-07-07 16:30:39 UTC

Created attachment 34960 [details, diff]
check string before writing to a file

Comment 2 Don Seiler (RETIRED) gentoo-dev

2004-07-07 20:10:28 UTC

This was fixed upstream with this patch:

http://cvs.sourceforge.net/viewcvs.py/gaim/gaim/src/account.c?r1=1.91&r2=1.92&diff_format=u

Does the same thing.  I'll use the upstream patch just to be consistent.

gaim-0.79-r2 now in portage.

Comment 3 devsk 2004-07-07 20:24:36 UTC

cool!!