Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 563876 - Failed to update file modify time on fetched binary packages from FTP
Summary: Failed to update file modify time on fetched binary packages from FTP
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Binary packages support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2015-10-23 13:20 UTC by Mike Hiretsky
Modified: 2016-03-14 04:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Change key MTIME to _mtime_ (binpkg_fetcher.patch,494 bytes, patch)
2015-10-23 13:30 UTC, Mike Hiretsky 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Hiretsky 2015-10-23 13:20:30 UTC 
Portage does not use already fetched from binhost tbz2 files. Probably portage does not fix mtime for fetched tbz2 files.

Reproducible: Always

Steps to Reproduce:
1. Set any ftp binhost
2. emerge app-misc/mc
3. emerge app-misc/mc
Actual Results:  
Refetching binary tbz2 

Expected Results:  
Will be used already fetched tbz2

I use sys-apps/portage-2.2.20.1.

At this commit will 

https://github.com/gentoo/portage/commit/328dd4712f88cbb8ef390ae9eb471afa1ef781d7

-				remote_mtime = bintree._remotepkgs[self.pkg.cpv].get("MTIME")
+				remote_mtime = bintree._remotepkgs[
+					bintree.dbapi._instance_key(
+					self.pkg.cpv)].get("MTIME")

_bintree.remotepkgs has not MTIME key, but has _mtime_.
Comment 1 Mike Hiretsky 2015-10-23 13:30:50 UTC 
Created attachment 415250 [details, diff]
Change key MTIME to _mtime_
Comment 3 Mike Hiretsky 2015-10-26 11:05:40 UTC 
Thank you, it works.
Comment 4 Zac Medico gentoo-dev 2016-03-14 04:03:47 UTC 
Fixed in 2.2.24.