Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 563802 - x11-themes/oxygen-gtk -- update config location && default tab style
Summary: x11-themes/oxygen-gtk -- update config location && default tab style
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-22 15:16 UTC by Alexey Kharlamov
Modified: 2017-06-24 14:17 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Kharlamov 2015-10-22 15:16:47 UTC
Problem #1: mainstream uses kde4-config, which does not return correct paths when it's running on plasma5 environments

Patch that fixes a problem: https://build.opensuse.org/package/view_file/KDE:Extra/oxygen-gtk2/qt-config-path.patch

Problem #2: TS_SINGLE tab style has been deprecated in oxygen qt style. Oxygen-gtk default config is still using TS_SINGLE, which should be replaced by TS_PLAIN:

sed -i 's/^\(TabStyle=\).*$/\1TS_PLAIN/' rc/oxygenrc
Comment 1 Michael Palimaka (kensington) gentoo-dev 2015-10-22 16:17:13 UTC
What is the difference in behaviour before and after these changes?

We can't apply them unconditionally, otherwise KDE4 users will get upset too.
Comment 2 Alexey Kharlamov 2015-10-22 16:31:22 UTC
Hmm...

Without any changes Oxygen-qt stores settings in ~/.config/oxygenrc, but Oxygen-gtk looks them in ~/.local/share/kde4/oxygenrc. On Plasma5 environments.

Moreover, command should be qtpaths -qt=qt5 ..., I suppose. 

>We can't apply them unconditionally, otherwise KDE4 users will get upset too.

Maybe it would be good to run all the available commands (not until the first successfull one) and use all of the paths. At last, Oxygen-gtk only reads configs, but does not create nor modify them. Should I change patch to do that or is there a better solution?
Comment 3 Andreas Sturmlechner gentoo-dev 2017-06-24 11:44:40 UTC
There are no Plasma-4 users left now, is this change still relevant?
Comment 4 Andreas Sturmlechner gentoo-dev 2017-06-24 14:17:04 UTC
Fixed in git commit cb8343823acdb727ff27c341d39d4ca5c369f736