Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 563082 - sys-block/open-iscsi: should not depend on virtual/udev
Summary: sys-block/open-iscsi: should not depend on virtual/udev
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-14 21:50 UTC by Jakub Jirutka
Modified: 2015-12-17 23:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Jirutka 2015-10-14 21:50:26 UTC
I don’t see any reason why should sys-block/open-iscsi require udev. This dependency was introduced in 2.0.872-r3 with reference to #556632. If I understand it correctly, it’s just about copying some rule files and scripts. This can be optional (USE udev?).

Why it bothers me? I don’t use either udev or eudev, simply because I don’t need such a complex and bloated solution on a server; busybox’s mdev is perfectly fine for me. However, mdev is not in virtual/udev, so it doesn’t satisfy this dependency.

Reproducible: Always
Comment 1 Julian Ospald 2015-10-15 11:13:04 UTC
If udev is a runtime-optional then it shouldn't even be in RDEPEND, but just be printed via elog in pkg_postinst(). Also, I think those files could be installed unconditionally, so there's no reason for an udev flag at all IMO.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-10-17 11:47:44 UTC
Let me rephrase what hasufell said.

Is there ever any reason to disable udev rules here? If there is, the patch looks acceptable to me. If there's not, we shouldn't have USE=udev and it'd be fine just to remove udev dependency... well, since it's more of a reverse dependency.
Comment 3 SpanKY gentoo-dev 2015-12-17 23:34:31 UTC
the udev rules are only used to probe devices automatically, so there's no need to depend on it
http://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2c1a8a62739b9cbbcb05c8af541383cdb1caa4f