Bug 562856 – dev-util/txt2regex ebuild does not install the script

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description René Rhéaume 2015-10-11 21:01:42 UTC]

The current txt2regex ebuild will not install the script that is txt2regex. It is a mistake in src_install which calls "emake" instead of "emake install".

There are two other problems in the ebuild
1. There is no need to call die with EAPI=5
2. By running make install, the Makefile will invoke sed to set the TEXTDOMAINDIR constant. However, if a DESTDIR is passed to make, that DESTDIR will be in the constant, i.e. you get TEXTDOMAINDIR=/var/tmp/portage/dev-util/txt2regex-0.8-r2/image/usr/share/locale instead of the correct TEXTDOMAINDIR=/usr/share/locale

Reproducible: Always

Steps to Reproduce:
1. emerge txt2regex
2. txt2regex
3.
Actual Results:  
zsh: command not found: txt2regex

Expected Results:  
txt2regex is run

[Comment 1 René Rhéaume 2015-10-11 21:03:20 UTC]

Created attachment 414394 [details, diff]
txt2regex-0.8-r2.ebuild.patch

[Comment 2 René Rhéaume 2015-10-11 21:04:40 UTC]

Created attachment 414396 [details, diff]
txt2regex-0.8-textdomaindir.patch

[Comment 3 Patrice Clement (RETIRED) 2015-10-13 19:16:42 UTC]

Indeed. Thanks a lot for picking up on this error. I'm going to try your patches and merge them ASAP.

[Comment 4 Patrice Clement (RETIRED) 2015-10-13 20:36:40 UTC]

commit 3fea42a (HEAD, master)
Author: Patrice Clement <[e-mail]>
Date:   Tue Oct 13 20:34:45 2015 +0000

    dev-util/txt2regex: Add patch to actually install txt2regex script courtesy of René Rhéaume <[e-mail]>. Fixes bug 562856.
    
    Package-Manager: portage-2.2.20.1
    Signed-off-by: Patrice Clement <[e-mail]>

 create mode 100644 dev-util/txt2regex/files/txt2regex-0.8-textdomaindir.patch
 create mode 100644 dev-util/txt2regex/txt2regex-0.8-r3.ebuild

Thank you!

[Comment 5 Patrice Clement (RETIRED) 2015-10-13 20:37:25 UTC]

I am going to stabilise this package right away since it is a fairly straightforward shell script.