Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 562532 - media-sound/teamspeak-client-bin-3.0.18 version bump
Summary: media-sound/teamspeak-client-bin-3.0.18 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Sami Loone
URL:
Whiteboard:
Keywords:
Depends on: 562778
Blocks:
  Show dependency tree
 
Reported: 2015-10-08 10:37 UTC by Bartosz Krzeszewski
Modified: 2016-01-01 01:19 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
teamspeak permission for gentoo (PERMISSION.eml,3.49 KB, message/rfc822)
2015-10-11 00:37 UTC, Sami Loone
Details
request for teamspeak direct link permission (PERMISSION-REQUEST.eml,4.29 KB, application/x-extension-eml)
2015-10-12 08:22 UTC, Sami Loone
Details
patch to lift fetch restrict (fetch-unrestrict-patch,9.17 KB, patch)
2015-10-13 05:53 UTC, Sami Loone
Details | Diff
version bump patch (version-bump.patch,17.92 KB, patch)
2015-10-23 05:07 UTC, Sami Loone
Details | Diff
teamspeak direct download permission for gentoo (PERMISSION.eml,7.78 KB, message/rfc822)
2016-01-01 00:27 UTC, Sami Loone
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bartosz Krzeszewski 2015-10-08 10:37:12 UTC
Actual version of TeamSpeak that you can download from https://www.teamspeak.com/downloads is 3.0.18
Comment 1 Andrew Savchenko gentoo-dev 2015-10-09 01:43:35 UTC
Current in-tree version can be downloaded from links used in the ebuild:
http://ftp.4players.de/pub/hosted/ts3/releases/3.0.17/TeamSpeak3-Client-linux_x86-3.0.17.run
http://ftp.4players.de/pub/hosted/ts3/releases/3.0.17/TeamSpeak3-Client-linux_amd64-3.0.17.run

I do not understand your issue. Or are you asking for a version bump?
Comment 2 Tomáš Mózes 2015-10-09 06:31:19 UTC
When you emerge this package, all it says is:

 * Please download TeamSpeak3-Client-linux_amd64-3.0.17.run
 * from http://www.teamspeak.com/?page=downloads and place this
 * file in /usr/portage/distfiles

So Bartosz probably went there and found version 3.0.18 and no files for 3.0.17. Yes, you can google for them or try to download, but he failed to find them.

Maybe the best would be to bump the version and drop the old ones.
Comment 3 Denis Misiurca 2015-10-10 21:18:58 UTC
3.18.1 was released containing an important security update http://forum.teamspeak.com/showthread.php/120755
Comment 4 Sami Loone 2015-10-10 22:14:21 UTC
3.0.18 doesn't work with the current portage qt5 versions.


=== Client Release 3.0.18 23 Sep 2015
+ Updated to Qt 5.5.0 for improved Windows 10 compatibility and to fix a crash
  seen in client 3.0.17

/opt/teamspeak3-client/ts3client: symbol lookup error: /opt/teamspeak3-client/ts3client: undefined symbol: _ZN9QMetaType22registerNormalizedTypeERK10QByteArrayPFvPvEPFS3_S3_PKvEi6QFlagsINS_8TypeFlagEEPK11QMetaObject
Comment 5 Sami Loone 2015-10-11 00:37:39 UTC
Created attachment 414300 [details]
teamspeak permission for gentoo

attached written permission for teamspeak software website direct link usage.

Received as an email from teamspeak.


This will allow us to remove the fetch restrict.
Comment 7 Ulrich Müller gentoo-dev 2015-10-12 05:55:47 UTC
(In reply to Sami Loone from comment #5)
> Created attachment 414300 [details]
> teamspeak permission for gentoo
> 
> attached written permission for teamspeak software website direct link usage.
> 
> Received as an email from teamspeak.
> 
> 
> This will allow us to remove the fetch restrict.

So, on their download site they say:

   "Mirroring or linking directly to our files is prohibited without our
   express, written consent."

and in the e-mail permission:

   "[...] as long as our licenses remain included and the binaries remain
   unchanged, we are approving a packaging of the TeamSpeak 3 software in
   your project."

This is somewhat vague, as it doesn't answer the two obvious questions: a) do they permit mirroring of their files (if yes, to whom?) and b) is linking to them allowed?

Also, what does "packaging" mean? We assume that our ebuilds are our own works with a copyright independent of the upstream package, so we don't need any upstream's permission to distribute them.
Comment 8 Sami Loone 2015-10-12 08:20:21 UTC
(In reply to Ulrich Müller from comment #7)
> (In reply to Sami Loone from comment #5)
> > Created attachment 414300 [details]
> > teamspeak permission for gentoo
> > 
> > attached written permission for teamspeak software website direct link usage.
> > 
> > Received as an email from teamspeak.
> > 
> > 
> > This will allow us to remove the fetch restrict.
> 
> So, on their download site they say:
> 
>    "Mirroring or linking directly to our files is prohibited without our
>    express, written consent."
> 
> and in the e-mail permission:
> 
>    "[...] as long as our licenses remain included and the binaries remain
>    unchanged, we are approving a packaging of the TeamSpeak 3 software in
>    your project."
> 
> This is somewhat vague, as it doesn't answer the two obvious questions: a)
> do they permit mirroring of their files (if yes, to whom?) and b) is linking
> to them allowed?
> 
> Also, what does "packaging" mean? We assume that our ebuilds are our own
> works with a copyright independent of the upstream package, so we don't need
> any upstream's permission to distribute them.

I have to agree. I did think of adding the permission request to the permission attachment. I will do that now that we have trust issues.
Comment 9 Sami Loone 2015-10-12 08:22:56 UTC
Created attachment 414410 [details]
request for teamspeak direct link permission

combining the request with the reply makes more sense.
Comment 10 Ulrich Müller gentoo-dev 2015-10-12 11:15:28 UTC
(In reply to Sami Loone from comment #9)
> Created attachment 414410 [details]
> request for teamspeak direct link permission
> 
> combining the request with the reply makes more sense.

Yes, your question was much clearer than their answer. ;) IMHO we can lift the fetch restriction then. Mirror restriction should remain in place, though.
Comment 11 Sami Loone 2015-10-12 18:18:17 UTC
Just tried 3.0.18.1 with qt 5.5.0 from qt overlay. Work like a charm.
Comment 12 Sami Loone 2015-10-13 05:53:54 UTC
Created attachment 414484 [details, diff]
patch to lift fetch restrict

patch to lift fetch restrict from 16-r1 and 17 client versions. Also includes exchanged emails for permission in licenses/.
Comment 13 wolfwood 2015-10-18 21:26:34 UTC
there is a security flaw in versions < 3.0.18 and many servers are blocking clients with unpatched versions.  qt5.5 is now in testing so the new ebuild will work without the qt overlay.
Comment 14 Karol Herbst 2015-10-19 02:01:50 UTC
(In reply to wolfwood from comment #13)
> there is a security flaw in versions < 3.0.18 and many servers are blocking
> clients with unpatched versions.  qt5.5 is now in testing so the new ebuild
> will work without the qt overlay.

I thought the flaw is inside <3.0.18.1. so the version should be bumped to 3.0.18.1 directly
Comment 15 Daniel Santos 2015-10-23 01:21:24 UTC
What I read was 3.0.18+ is fixed, but I would still bump to 3.0.18.1 if there is not a reason to use only 3.0.18. I kinda ran into this problem too, none of the servers I use (about 5 of them) will let me log in until I upgrade.
Comment 16 Sami Loone 2015-10-23 05:07:28 UTC
Created attachment 415220 [details, diff]
version bump patch

version bumps to 3.0.18.2 and removes the fetch restrict

cd /usr/portage && git apply <patch>
Comment 17 Ian Delaney (RETIRED) gentoo-dev 2015-11-07 05:32:04 UTC
(In reply to Sami Loone from comment #16)
> Created attachment 415220 [details, diff] [details, diff]
> version bump patch
> 
> version bumps to 3.0.18.2 and removes the fetch restrict
> 
> cd /usr/portage && git apply <patch>

According to ulm it will suffice for the bump to have a single attachment of the email lodged here in the bug which is cited in the commit message of the bump to 3.0.18.2, and retain restrict "mirror"
Comment 18 Bartosz Krzeszewski 2015-11-28 01:19:24 UTC
Will it ever work?
Comment 19 Ian Delaney (RETIRED) gentoo-dev 2015-12-03 14:44:36 UTC
Will what ever work? After getting the reply for ulm I am waiting to enact it.
Comment 20 Sami Loone 2015-12-31 21:53:46 UTC
https://github.com/gentoo/gentoo/pull/581

Pull request issued. This only bumps the version and does not include the
permission changes. We should create a new bug just for the permission change so we can get the version bumped.
Comment 21 Sami Loone 2016-01-01 00:27:37 UTC
Created attachment 421386 [details]
teamspeak direct download permission for gentoo

Combined permission request/response emails to one attachment.
Comment 22 Sami Loone 2016-01-01 01:00:49 UTC
Pull request was merged:

https://github.com/gentoo/gentoo/pull/583
Comment 23 Ian Delaney (RETIRED) gentoo-dev 2016-01-01 01:19:30 UTC
commit a015868f7c1686f004ecbd29696109ed3942b1c3
Author: Sami Loone <dryatu@gmail.com>
Date:   Thu Dec 31 23:42:06 2015 +0200

    media-sound/teamspeak-client-bin: version bump to 3.0.18.2
    
    Bumped version and removed old vulnerable versions. New version
    requires >=5.5 qt instead of >=5.
    
    Bug: 562532

commit 61a0c8631f66766d5fabe48e3812a44589a5611e
Author: Sami Loone <dryatu@gmail.com>
Date:   Fri Jan 1 02:49:50 2016 +0200

    media-sound/teamspeak-client-bin: fetch restrict removed
    
    Permission for direct download of teamspeak software from teamspeak
    mirrors has been granted for Gentoo Linux. Fetch restrict is gone
    but we now need to restrict mirroring. Details of this special
    permission are discussed in the Gentoo Bugzilla.
    
    Permission email: https://bugs.gentoo.org/attachment.cgi?id=421386
    
    Gentoo-Bug: 562532