Created attachment 413858 [details] build.log Hello. wpa_supplicant-2.5[wimax] produces this output on merge attempt: * Cannot find $EPATCH_SOURCE! Value for $EPATCH_SOURCE is: * * /var/portage/net-wireless/wpa_supplicant/files/wpa_supplicant-2.5-generate-libeap-peer.patch * ( wpa_supplicant-2.5-generate-libeap-peer.patch ) This is due to this line: https://github.com/gentoo/gentoo/blob/master/net-wireless/wpa_supplicant/wpa_supplicant-2.5.ebuild#L103 After version bump ${P} has changed, so either patch should be renamed, or reference should be updated to ${PN}-2.4 Please fix.
Created attachment 413860 [details] emerge --info
Also 2.4 patch does not apply cleanly anymore because of this commit: https://w1.fi/cgit/hostap/commit/src/eap_peer/Makefile?id=46c3befe24be715d2bb8083214f21dfbbebc85f4
You bumped it, so you fix it :-)
*** Bug 562378 has been marked as a duplicate of this bug. ***
(In reply to Bjarke Istrup Pedersen from comment #3) > You bumped it, so you fix it :-) another way to see it is that I did most of the work, you could help :-P
(In reply to Rick Farina (Zero_Chaos) from comment #5) > (In reply to Bjarke Istrup Pedersen from comment #3) > > You bumped it, so you fix it :-) > another way to see it is that I did most of the work, you could help :-P Fixing the dbus patch is easy - it just needs to be copied and uncommented. The generate-libeap-peer patch needs to be merged. I have tried, but haven't been able to get it to work. I'm currently for removing the 2.5 ebuild until we can come up with a fix. What do you suggest?
(In reply to Bjarke Istrup Pedersen from comment #6) > Fixing the dbus patch is easy - it just needs to be copied and uncommented. Actually most of the dbus patch was merged, so I had to work through the code to see if our changes were needed or not, and most of them no longer were. > > The generate-libeap-peer patch needs to be merged. Yes, although some of it seems to have been already, like the fact that libeap-peer gets built > > I have tried, but haven't been able to get it to work. > I'm currently for removing the 2.5 ebuild until we can come up with a fix. > > What do you suggest? I suggest that we mask the use flag on the affected version. A *minor* feature like wimax should not stop the majority of the users from using the new version.
(In reply to Coacher from comment #0) > Created attachment 413858 [details] > build.log > > Hello. > > wpa_supplicant-2.5[wimax] produces this output on merge attempt: > > * Cannot find $EPATCH_SOURCE! Value for $EPATCH_SOURCE is: > * > * > /var/portage/net-wireless/wpa_supplicant/files/wpa_supplicant-2.5-generate- > libeap-peer.patch > * ( wpa_supplicant-2.5-generate-libeap-peer.patch ) > > This is due to this line: > https://github.com/gentoo/gentoo/blob/master/net-wireless/wpa_supplicant/ > wpa_supplicant-2.5.ebuild#L103 > > After version bump ${P} has changed, so either patch should be renamed, or > reference should be updated to ${PN}-2.4 > > Please fix. I know this is a dumb request, but can you please build without the wimax use flag and confirm that it doesn't work? The patch is pretty big but it looks like at least some of the critical changes are merged in and I wonder if it's enough to make it work.
(In reply to Rick Farina (Zero_Chaos) from comment #8) > I know this is a dumb request, but can you please build without the wimax > use flag and confirm that it doesn't work? The patch is pretty big but it > looks like at least some of the critical changes are merged in and I wonder > if it's enough to make it work. net-wireless/wpa_supplicant-2.5[-wimax] builds and works fine, i.e. I can get a working Wi-Fi connection.
(In reply to Coacher from comment #9) > (In reply to Rick Farina (Zero_Chaos) from comment #8) > > I know this is a dumb request, but can you please build without the wimax > > use flag and confirm that it doesn't work? The patch is pretty big but it > > looks like at least some of the critical changes are merged in and I wonder > > if it's enough to make it work. > > net-wireless/wpa_supplicant-2.5[-wimax] builds and works fine, i.e. I can > get a working Wi-Fi connection. but are you able to test any of the wimax functionality, or were you enabling that flag for the fun of using random patches?
(In reply to Rick Farina (Zero_Chaos) from comment #10) > but are you able to test any of the wimax functionality, or were you > enabling that flag for the fun of using random patches? No, I don't have wimax hardware. I was looking through wpa_supplicant-2.5 ebuild and found that wimax USE is broken because of a missing patch. Tested and indeed it is broken, then reported.
(In reply to Coacher from comment #11) > (In reply to Rick Farina (Zero_Chaos) from comment #10) > > but are you able to test any of the wimax functionality, or were you > > enabling that flag for the fun of using random patches? > > No, I don't have wimax hardware. I was looking through wpa_supplicant-2.5 > ebuild and found that wimax USE is broken because of a missing patch. Tested > and indeed it is broken, then reported. cool, thanks for the report. for now, the flag is masked. I'll work on it, but absent people with hardware (and service) to test this will be difficult to fix. I can make the patch apply with enough effort, but that hardly seems enough.
Created attachment 414056 [details, diff] wpa_supplicant-2.5-do-not-call-dbus-functions-with-NULL-path.patch (In reply to Rick Farina (Zero_Chaos) from comment #12) > cool, thanks for the report. for now, the flag is masked. I'll work on it, > but absent people with hardware (and service) to test this will be difficult > to fix. I can make the patch apply with enough effort, but that hardly > seems enough. It is fine by me. Thank you. Also I've turned wpa_supplicant-2.5-do-not-call-dbus-functions-with-NULL-path.patch into a proper git patch, because the current one looks a bit clumsy to me. This is purely cosmetics change though.
wimax is masked, unless a tester appears it will simply be removed with the next rev-bump. thanks for the report.
(In reply to Rick Farina (Zero_Chaos) from comment #14) > wimax is masked, unless a tester appears it will simply be removed with the > next rev-bump. > > thanks for the report. Fair enough. Thank you for your time. Would you mind to make wpa_supplicant-2.5-do-not-call-dbus-functions-with-NULL-path.patch ([2]) consistent with other wpa_supplicant patches ([0], [1]) by removing that ugly wpa_supplicant-fixed/ path, please? This ugly path appeared after porting the patch from 2.4 series. I've attached cleaner version above. [0]: https://gitweb.gentoo.org/repo/gentoo.git/tree/net-wireless/wpa_supplicant/files/wpa_supplicant-2.4-dbus-path-fix.patch [1]: https://gitweb.gentoo.org/repo/gentoo.git/tree/net-wireless/wpa_supplicant/files/wpa_supplicant-2.4-do-not-call-dbus-functions-with-NULL-path.patch [2]: https://gitweb.gentoo.org/repo/gentoo.git/tree/net-wireless/wpa_supplicant/files/wpa_supplicant-2.5-do-not-call-dbus-functions-with-NULL-path.patch
honestly, I couldn't care less about this. but since you cared enough to complain, it's fixed now ;-)
(In reply to Rick Farina (Zero_Chaos) from comment #16) > honestly, I couldn't care less about this. but since you cared enough to > complain, it's fixed now ;-) Thank you. That commit message makes me happy indeed:)
Please adjust the current wimax USE mask: =net-wireless/wpa_supplicant-2.5 wimax It won't match =net-wireless/wpa_supplicant-2.5-r1.
The mask has been fixed - thanks :-)
