Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 561668 - media-gfx/shotwell-0.22.0 does not respect linguas
Summary: media-gfx/shotwell-0.22.0 does not respect linguas
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-27 21:37 UTC by Jan Vesely
Modified: 2015-10-15 12:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
shotwell: Fix LINGUAS support (0001-media-gfx-shotwell-Fix-LINGUAS-support.patch,1.95 KB, patch)
2015-09-27 21:39 UTC, Jan Vesely 		Details | Diff
shotwell: Fix LINGUAS support v2 (0001-media-gfx-shotwell-Fix-LINGUAS-support.patch,1.92 KB, patch)
2015-10-13 01:00 UTC, Jan Vesely 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Vesely 2015-09-27 21:37:06 UTC 
shotwell installs support for all 65 languages irrespective of the LINGUAS variable setting.

Reproducible: Always
Comment 1 Jan Vesely 2015-09-27 21:39:22 UTC 
Created attachment 413098 [details, diff]
shotwell: Fix LINGUAS support
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2015-10-10 08:11:37 UTC 
Thanks for the report. Sadly your patch isn't working. with LINGUAS="" it breaks the build.
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2015-10-10 11:19:37 UTC 
commit 12d196f35ba772eb28a9b81b6db831c912d5237e
Author: Justin Lecher <jlec@gentoo.org>
Date:   Sat Oct 10 10:27:21 2015 +0200

    media-gfx/shotwell: Properly support linguas

    Thanks Jan Vesely for the patch

    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=561668

    Package-Manager: portage-2.2.22
    Signed-off-by: Justin Lecher <jlec@gentoo.org>

    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=12d196f35ba772eb28a9b81b6db831c912d5237e
Comment 4 Jan Vesely 2015-10-13 01:00:55 UTC 
Created attachment 414472 [details, diff]
shotwell: Fix LINGUAS support v2

thanks for handling this. the solution fixes my problem (I have en_GB in LINGUAS). however, I think it'd be better to support empty LINGUAS set.

I have attached v2 of the patch that moves lang removal back to install phase.
This time I have tested that it works with empty LINGUAS.
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2015-10-15 12:54:44 UTC 
(In reply to Jan Vesely from comment #4)
> Created attachment 414472 [details, diff] [details, diff]
> shotwell: Fix LINGUAS support v2
> 
> thanks for handling this. the solution fixes my problem (I have en_GB in
> LINGUAS). however, I think it'd be better to support empty LINGUAS set.
> 
> I have attached v2 of the patch that moves lang removal back to install
> phase.
> This time I have tested that it works with empty LINGUAS.


Could you please update your patch to the latest version of the ebuild and send a PR at GH?