Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 561132 - x11-terms/roxterm-3.1.5 version bump
Summary: x11-terms/roxterm-3.1.5 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Russell Knighton
URL: http://sourceforge.net/projects/roxte...
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks: vte-2.90-deprecation
  Show dependency tree
 
Reported: 2015-09-22 12:08 UTC by Russell Knighton
Modified: 2015-11-10 19:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
roxterm-3.1.5.ebuild (roxterm-3.1.5.ebuild,1.26 KB, text/plain)
2015-09-22 12:11 UTC, Russell Knighton
Details
roxterm-3.1.5.ebuild (roxterm-3.1.5.ebuild,1.26 KB, text/plain)
2015-09-28 14:20 UTC, Russell Knighton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Russell Knighton 2015-09-22 12:08:34 UTC
Newer version of roxterm.

Main headline (that I was concerned about) is it now depends on x11-libs/vte:2.9.1 (which will help with #538140).

Reproducible: Always
Comment 1 Russell Knighton 2015-09-22 12:11:26 UTC
Created attachment 412552 [details]
roxterm-3.1.5.ebuild

Working ebuild for new version. Copied from original 2.9.3 ebuild with following modifications:
--- /usr/portage/x11-terms/roxterm/roxterm-2.9.3-r1.ebuild	2015-08-09 21:34:56.000000000 +0100
+++ roxterm-3.1.5.ebuild	2015-09-22 12:58:33.176088622 +0100
@@ -4,12 +4,12 @@

 EAPI=5

-PYTHON_COMPAT=( python2_7 )
+PYTHON_COMPAT=( python{2_7,3_3,3_4} )
 inherit gnome2-utils python-any-r1 toolchain-funcs

 DESCRIPTION="A terminal emulator designed to integrate with the ROX environment"
 HOMEPAGE="http://roxterm.sourceforge.net/"
-SRC_URI="mirror://sourceforge/roxterm/${P}.tar.bz2"
+SRC_URI="mirror://sourceforge/roxterm/${P}.tar.xz"

 LICENSE="GPL-2 LGPL-3"
 SLOT="0"
@@ -21,7 +21,7 @@
 	x11-libs/gtk+:3
 	x11-libs/libICE
 	x11-libs/libSM
-	x11-libs/vte:2.90"
+	x11-libs/vte:2.91"
 DEPEND="${RDEPEND}
 	${PYTHON_DEPS}
 	dev-libs/libxslt
Comment 2 Pacho Ramos gentoo-dev 2015-09-22 18:53:09 UTC
This package lacks a maintainer now... would you like to proxy maintain it? :)
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

Thanks!
Comment 3 Russell Knighton 2015-09-23 09:07:58 UTC
(In reply to Pacho Ramos from comment #2)
> This package lacks a maintainer now... would you like to proxy maintain it?
> :)
> https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
> 
> Thanks!

I've had a quick read of the wiki page and I'd be delighted to - I always have wanted to get more involved and this will be a good first step.
Comment 4 Pacho Ramos gentoo-dev 2015-09-23 18:45:53 UTC
Nice to know, I will CC proxy-maint people then :)

Thanks!
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2015-09-26 13:54:09 UTC
The shebang of the python script to work this package is mscript.py 
"#!/usr/bin/env python3"  making it python3 only. The script of 2.9.3 has plain python. Emerging using python2 cause it to fail with "python3 is not supported by python2.7"
Means python2_7 need be removed from PYTHON_COMPAT, setting a proper slot for glib and the deps could be indented to the usual 2 tab spaces.
On submitting these minor changes I can add it to portage
Comment 6 Russell Knighton 2015-09-28 14:20:34 UTC
Created attachment 413200 [details]
roxterm-3.1.5.ebuild

Thanks Ian - made the changes as requested.

If the 2 tab's within the DEPEND strings is the new norm/standard, can I suggest the https://devmanual.gentoo.org/ebuild-writing/file-format/ page be updated to clarify?
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2015-10-04 08:09:21 UTC
(In reply to Russell Knighton from comment #6)
> Created attachment 413200 [details]
> roxterm-3.1.5.ebuild
> 
> Thanks Ian - made the changes as requested.
> 
> If the 2 tab's within the DEPEND strings is the new norm/standard, can I
> suggest the https://devmanual.gentoo.org/ebuild-writing/file-format/ page be
> updated to clarify?

Oddly the edit I'd make on that page is shifting  Each tab represents four spaces to  Each tab represents ten spaces. The convention to use 2 tab space appears to have forged its own path of legitimacy. I might check with some others if this warrants changing.

I've taken the liberty of making the edited ebuild set with SLOT="1".
versions 2.n are py2 compatible. versions 3.n are py3 compatible. Within the python herd these typically are slotted to distinguish the compatibility with the python impl.

commit e39b5a80ecea96e41e9dc49ab012451b5aefdc4d
Author: Ian Delaney <idella4@gentoo.org>
Date:   Sun Oct 4 16:03:47 2015 +0800

    x11-terms/roxterm:  bump to -3.1.5
    
    ebuild by new maintainer sourced from the gentoo bug. The version
    is python 3 compatible only and set SLOT value 1
    
    Gentoo bug: #561132

Next for this package, roxterm-2.9.3-r1.ebuild needs a stable request to update the current roxterm-2.6.3.ebuild, then those prior to -2.9.3-r1 may be purged.
The new -3.1.5 requires the mandatory period free of bugs before making a stable request.
Comment 8 Martin von Gagern 2015-11-09 20:28:12 UTC
(In reply to Ian Delaney from comment #7)
> I've taken the liberty of making the edited ebuild set with SLOT="1".
> versions 2.n are py2 compatible. versions 3.n are py3 compatible. Within the
> python herd these typically are slotted to distinguish the compatibility
> with the python impl.

Such kind of slotting makes perfect sense if all the package does is installing a bunch into pythons site-packages directory, so they can be installed simultaneously. That's not the case for roxterm, which installs files in other locations as well and therefore can't have both versions installed simultaneously. See bug #565288. I suggest you un-slot things, or add a blocker.
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2015-11-10 06:40:48 UTC
Very well, you need submit a patch here accordingly.
Comment 10 Pacho Ramos gentoo-dev 2015-11-10 19:17:53 UTC
It will be better to use the concrete bug report for that new issue instead of reusing the old bug that is full of other things :/