Created attachment 412368 [details, diff] isoroot verify feature which is already in genkernel I will document how this works once we agree on it, for right now if livecd/verify is set to *anything* it will make the checksums. I think that is fine personally, and it keeps the code much simpler than trying to handle all the possible negative values like "no|No|n|NO|false|False|FALSE|f" etc. please ACK or make suggestions.
Created attachment 412378 [details, diff] updated patch updated patch to include documentation for currently coded functionality
The method of adding the option is fine with me. As I don't do anything with the releases, I have no opinion about the validity of it. But it is optional, so, I don't have a problem with it.
Instead of calling isoroot_checksum unconditionally and have the function be a no-op when clst_livecd_verify isn't set, I'd prefer only call isoroot_checksum when the variable is set in the spec.
Created attachment 412440 [details, diff] moar conditionals this patch has the added conditionals as requested by jmbsvicetto, however, I think it is really ugly to have 6 checks instead of 1
Created attachment 412444 [details, diff] new function to reduce copy pasta this version of the patch based on discussion with jmbsvicetto on irc
(In reply to Rick Farina (Zero_Chaos) from comment #4) > Created attachment 412440 [details, diff] [details, diff] > moar conditionals > > this patch has the added conditionals as requested by jmbsvicetto, however, > I think it is really ugly to have 6 checks instead of 1 I also prefer the one check in isoroot_checksum() myself instead of 6 conditionals which isoroot_checksum() does as is.
(In reply to Fernando (likewhoa) from comment #6) > I also prefer the one check in isoroot_checksum() myself instead of 6 > conditionals which isoroot_checksum() does as is. please see latest patch then
a modified version of this has been committed based on testing and feedback. https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=2b0e9243fb2456e86053b9448938359920916ecc
