Bug 560660 – gnome-extra/cinnamon-control-center-2.6.0 ../../shell/cc-panel.h:28:25: fatal error: glib-object.h: No such file or directory

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Garry Filakhtov 2015-09-16 18:28:05 UTC]

Found a bug in cinnamon-control-center-2.6.0-optional.patch, that should make colord dependency optional, but fails to do so.

Reproducible: Always

Steps to Reproduce:
1. disable colord USE flag and try to emerge cinnamon-control-center
Actual Results:  
Build fails with:

cc-color-panel.c:24:20: fatal error: colord.h: No such file or directory
 #include <colord.h>
                    ^
compilation terminated.
In file included from cc-color-panel.h:26:0,
                 from color-module.c:25:
../../shell/cc-panel.h:28:25: fatal error: glib-object.h: No such file or directory
 #include <glib-object.h>
                         ^
compilation terminated.

Expected Results:  
Build succeed

Patch for optional colord is broken.
"color" flag was not removed from panel/Makefile.am

[Comment 1 Garry Filakhtov 2015-09-16 18:30:49 UTC]

Created attachment 412076 [details, diff]
correct patch

[Comment 2 Pacho Ramos 2015-11-15 21:43:20 UTC]

fixed in 2.8, thanks!