Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 560084 - gnome-base/gnome-vfs-2.24.4-r3 fails with >=net-libs/gnutls-3.4.0
Summary: gnome-base/gnome-vfs-2.24.4-r3 fails with >=net-libs/gnutls-3.4.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
: 583088 (view as bug list)
Depends on:
Blocks: gnutls-3.5-breakage
  Show dependency tree
 
Reported: 2015-09-10 01:27 UTC by Andrew John Hughes
Modified: 2016-06-11 20:24 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Use new priority API with updated defaults (gnome-vfs-2.24.4-gnutls34.patch,1.73 KB, patch)
2015-09-10 01:55 UTC, Andrew John Hughes
Details | Diff
build.log gnome-base/gnome-vfs-2.24.4-r4 failure (build.log,465.92 KB, text/plain)
2016-05-12 19:24 UTC, Gary E. Miller
Details
emerge-info.txt (emerge-info.txt,6.56 KB, text/plain)
2016-05-13 08:12 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,180.17 KB, text/plain)
2016-05-13 08:13 UTC, Toralf Förster
Details
environment (environment,153.35 KB, text/plain)
2016-05-13 08:13 UTC, Toralf Förster
Details
gnome-base:gnome-vfs-2.24.4-r4:20160513-033544.log (gnome-base:gnome-vfs-2.24.4-r4:20160513-033544.log,430.78 KB, text/plain)
2016-05-13 08:13 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew John Hughes 2015-09-10 01:27:15 UTC
/mnt/builder/portage.build/portage/gnome-base/gnome-vfs-2.24.4-r3/work/gnome-vfs-2.24.4-abi_x86_32.x86/libgnomevfs/.libs/libgnomevfs-2.so: undefined reference to `gnutls_protocol_set_priority'
/mnt/builder/portage.build/portage/gnome-base/gnome-vfs-2.24.4-r3/work/gnome-vfs-2.24.4-abi_x86_32.x86/libgnomevfs/.libs/libgnomevfs-2.so: undefined reference to `gnutls_mac_set_priority'
/mnt/builder/portage.build/portage/gnome-base/gnome-vfs-2.24.4-r3/work/gnome-vfs-2.24.4-abi_x86_32.x86/libgnomevfs/.libs/libgnomevfs-2.so: undefined reference to `gnutls_kx_set_priority'
/mnt/builder/portage.build/portage/gnome-base/gnome-vfs-2.24.4-r3/work/gnome-vfs-2.24.4-abi_x86_32.x86/libgnomevfs/.libs/libgnomevfs-2.so: undefined reference to `gnutls_cipher_set_priority'
/mnt/builder/portage.build/portage/gnome-base/gnome-vfs-2.24.4-r3/work/gnome-vfs-2.24.4-abi_x86_32.x86/libgnomevfs/.libs/libgnomevfs-2.so: undefined reference to `gnutls_compression_set_priority'


Reproducible: Always

Steps to Reproduce:
1. Install gnutls >= 3.4.4.1
2. Build gnome-vfs 2.24.4-r3
3.
Actual Results:  
Compile fails.

Expected Results:  
Compile succeeds.

These functions were removed in 3.4:

http://www.gnutls.org/manual/gnutls.html#Upgrading-from-previous-versions
Comment 1 Andrew John Hughes 2015-09-10 01:55:53 UTC
Created attachment 411468 [details, diff]
Use new priority API with updated defaults

The attached patch replaces the outdated API calls with the new priority system in 3.4. Instead of doing a like-for-like replacement, we enable the secure defaults ("NORMAL") plus compression. This is preferable to turning on options now known to be insecure (SSLv3, RC4) and turning off newer options (TLSv1.2, ECC), which the old priority settings suggest.
Comment 2 Gary E. Miller 2016-05-12 19:24:16 UTC
gnome-base/gnome-vfs-2.24.4-r4 also fails to emerge.

[...]
/u1/tmp/portage/gnome-base/gnome-vfs-2.24.4-r4/work/gnome-vfs-2.24.4-abi_x86_32.x
86/libgnomevfs/.libs/libgnomevfs-2.so: undefined reference to `gnutls_cipher_set_
priority'
[...]
Comment 3 Gary E. Miller 2016-05-12 19:24:53 UTC
Created attachment 434106 [details]
build.log gnome-base/gnome-vfs-2.24.4-r4 failure
Comment 4 Toralf Förster gentoo-dev 2016-05-13 08:12:59 UTC
Created attachment 434166 [details]
emerge-info.txt

"nn"/bin/sh ../libtool  --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc  -march=native -O2 -pipe  -Wl,-O1 -Wl,--as-needed -o gnome-vfs-daemon dbus-utils.o vfs-daemon.o daemon-connection.o -lgmodule-2.0 -pthread -lgthread-2.0 -pthread -lgconf-2 -lxml2 -ldbus-glib-1 -ldbus-1 -lgobject-2.0 -lglib-2.0  -lgnutls -lgcrypt -lgpg-error   -lresolv -lglib-2.0 ../libgnomevfs/libgnomevfsdaemon-2.la ../libgnomevfs/
libtool: link: x86_64-pc-linux-gnu-gcc -march=native -O2 -pipe -Wl,-O1 -o .libs/gnome-vfs-daemon dbus-utils.o vfs-daemon.o daemon-connection.o -pthread -pthread  -Wl,--as-needed ../libgnomevfs/.libs/libgnomevfsdaemon-2.a /var/tmp/portage/gnome-base/gnome-vfs-2.24.4-r4/work/gnome-vfs-2.24.4-abi_x86_64.amd64/libgnomevfs/.libs/libgnomevfs-2.so ../libgnomevfs/.libs/libgnomevfs-2.so -lgmodule-2.0 -lgth
/var/tmp/portage/gnome-base/gnome-vfs-2.24.4-r4/work/gnome-vfs-2.24.4-abi_x86_64.amd64/libgnomevfs/.libs/libgnomevfs-2.so: undefined reference to `gnutls_cipher_set_priority'
Comment 5 Toralf Förster gentoo-dev 2016-05-13 08:13:02 UTC
Created attachment 434168 [details]
emerge-history.txt
Comment 6 Toralf Förster gentoo-dev 2016-05-13 08:13:05 UTC
Created attachment 434170 [details]
environment
Comment 7 Toralf Förster gentoo-dev 2016-05-13 08:13:08 UTC
Created attachment 434172 [details]
gnome-base:gnome-vfs-2.24.4-r4:20160513-033544.log
Comment 8 Juergen Rose 2016-05-13 15:29:30 UTC
I have the same issue.
Comment 9 Billy DeVincentis 2016-05-15 10:51:12 UTC
me too
Comment 10 PhobosK 2016-05-15 17:59:23 UTC
the proposed 'Use new priority API with updated defaults' works for me in compilation
Comment 11 Mark Dominik Bürkle 2016-05-15 21:25:50 UTC
proposed patch added as epatch paragraph in src_prepare works for me, too:

lapmdb-hpl ~ #>> diff -wu /usr/portage/gnome-base/gnome-vfs/gnome-vfs-2.24.4-r4.ebuild /usr/local/portage/gnome-base/gnome-vfs/gnome-vfs-2.24.4-r4.ebuild 
--- /usr/portage/gnome-base/gnome-vfs/gnome-vfs-2.24.4-r4.ebuild	2015-11-19 11:03:35.000000000 +0100
+++ /usr/local/portage/gnome-base/gnome-vfs/gnome-vfs-2.24.4-r4.ebuild	2016-05-15 23:13:29.658235294 +0200
@@ -86,6 +86,9 @@
 	# Fix for automake-1.13 compatibility, #466944
 	epatch "${FILESDIR}"/${P}-automake-1.13.patch
 
+	# Fix building with gnutls-3.4+, bug #560084
+	epatch "${FILESDIR}"/${PN}-2.24.4-gnutls34.patch
+
 	sed -e "s/AM_CONFIG_HEADER/AC_CONFIG_HEADERS/" -i configure.in || die
 
 	eautoreconf
lapmdb-hpl ~ #>>
Comment 12 Juergen Rose 2016-05-16 12:27:13 UTC
The patch of comment 1 works for me too.
Comment 13 tman 2016-05-18 15:20:23 UTC
(In reply to Juergen Rose from comment #12)
> The patch of comment 1 works for me too.

i put this patch in /etc/portage/patches/gnome-base/gnome-vfs but it dont work.
Comment 14 Martin von Gagern 2016-05-18 20:04:41 UTC
(In reply to tman from comment #13)
> i put this patch in /etc/portage/patches/gnome-base/gnome-vfs but it dont
> work.

Unfortunately gnome-vfs doesn't support epatch_user, so /etc/portage/patches won't be honored. You can edit the ebuild yourself, or perform the unpack and merge steps separately like this:

 ebuild $(equery which gnome-vfs) clean unpack
 wget -O- 'https://bugs.gentoo.org/attachment.cgi?id=411468' \
 | patch -p0 -d /var/tmp/portage/gnome-base/gnome-vfs-*/work/gnome-vfs-*
 ebuild $(equery which gnome-vfs) merge

Compiles for me, thanks Andrew! Not tested at runtime, since I'm not much of a Gnome user.
Comment 15 Greg Turner 2016-05-19 21:46:09 UTC
For those having trouble with this, the patch Andrew John Hughes provided sort-of patches the wrong file.  The first reference to libgnomevfs/gnome-vfs-ssl.c.old (the part with the minuses next to it in the patch) should be changed to libgnomevfs/gnome-vfs-ssl.c.

I am guessing epatch has some built-in magic, somewhere, to detect this situation and work around it.  But if you are just wedging it in there yourself, you may need to make the aforementioned change.
Comment 16 Rémi Cardona (RETIRED) gentoo-dev 2016-05-21 10:47:02 UTC
*** Bug 583088 has been marked as a duplicate of this bug. ***
Comment 17 Joerg Neikes 2016-05-25 11:55:21 UTC
This patch works for me too in running environment.

Error exists also in gnome-vfs/gnome-vfs-2.24.4-r4 .


vi /usr/portage/gnome-base/gnome-vfs/gnome-vfs-2.24.4-r4.ebuild

below:

    eautoreconf
    gnome2_src_prepare
}

add:

post_src_prepare() {
epatch_user
} 

save the ebuild file.

ebuild /usr/portage/gnome-base/gnome-vfs/gnome-vfs-2.24.4-r4.ebuild digest
mkdir -p /etc/portage/patches/gnome-base/gnome-vfs-2.24.4-r4
cd /etc/portage/patches/gnome-base/gnome-vfs-2.24.4-r4

wget "https://560084.bugs.gentoo.org/attachment.cgi?id=411468" -O gnutls-3.4.0.patch

emerge gnome-base/gnome-vfs
Comment 18 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-06-10 14:24:45 UTC
Arch patch [1] uses gnutls_set_default_priority() instead. Any rationale for your patch?

[1]:https://archlinuxarm.org/packages/arm/gnome-vfs/files/gnutls-3.4.0.patch
Comment 19 Weedy 2016-06-11 19:40:00 UTC
We are nearing on 1 year old with this. Can we just push a fix?

I've been using the submitters patch for probably 6 months now.
He posted his rationale when he made the patch.

(In reply to Andrew John Hughes from comment #1)
> Instead of doing a like-for-like replacement, we enable the
> secure defaults ("NORMAL") plus compression.
> This is preferable to turning on options now known to be 
> insecure (SSLv3, RC4) and turning off newer options (TLSv1.2, ECC), 
> which the old priority settings suggest.
Comment 20 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-06-11 20:24:29 UTC
commit 3ed0516c7dc1c1162f1924e00965d4f3f931f021
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: Sat Jun 11 22:16:00 2016
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: Sat Jun 11 22:22:40 2016

    gnome-base/gnome-vfs: Fix gnutls-3.4+ compatibility, #560084


Thank you for the patch but policies considered, I've decided it's better to take the one from Arch that uses unmodified system defaults. I know it's got broken error handling -- but then, all the code in gnome-vfs is similarly bad, so it shouldn't matter much.