Created attachment 411286 [details] Replacement python script Per Robin's request in [1] I updated the scripts and provided them in replies to that thread[2], and later cc: Robin. [3] Since he's presumably busy - and tracking multiple revisions of scripts in e-mail is a pain - opening this bug to track. [1] https://archives.gentoo.org/gentoo-dev/message/0fc5dc1915ba1d6b28f7d8674b95a91f [2] https://archives.gentoo.org/gentoo-dev/message/32879869bb516c82e565650a7908c418 [3] https://archives.gentoo.org/gentoo-dev/message/329fede3822a98e30a5781d0fc917fd9
Created attachment 411288 [details] Replacement shell-wrapper
Created attachment 411290 [details] Replacement python script v2 Fixes some date comments made by titanofold/kentfredric on the gentoo-dev thread.
Created attachment 411864 [details] Replacement python script v3 Use committer (%cE), rather than author (%aE) since we simplified to remove the @... part of the e-mail assuming @gentoo.org
The tweaked version of this is now live, but there is a major problem I see: you're detecting Manifest addition/removal as a package being added/removed, but that is NO longer accurate with thin Manifests. If the package has no distfiles, there will be NO thin Manifest. It needs to be detecting the addition of a directory, not just the files.
Hey Robin, sorry for the delay in response - been in India w/work for 10 days. I see your point, I hadn't considered thin-manifest. I've had a look, but my jet-lagged brain can't seem to see a way to make git log output the fact that directories were added, it seems to be implied. Everything *should* have metadata.xml tho, right?[1] Which means you can just s/Manifest/metadata.xml/ in the python script -new_package = re.compile("^A\s+(.*)\/(.*)\/Manifest$") -removed_package = re.compile("^D\s+(.*)\/(.*)\/Manifest$") +new_package = re.compile("^A\s+(.*)\/(.*)\/metadata.xml$") +removed_package = re.compile("^D\s+(.*)\/(.*)\/metadata.xml$") I tested this and it does pick up an additional > net-misc/connman-ui 2015-09-29 20:49:35 hasufell f77f4fa compared to the Manifest-based version - and that *is* a GIT-only ebuild with no distfiles. BTW Did you push the code to some infra repo? It would make sending patches easier :) Cheers, malc. [1] Used this hack to dump <cat/pn>'s without metadata.xml and found none for i in `find ./ -wholename "*/*" -type d | grep "/.*/" | grep -v "/.*/.*/"` ; do ls $i/metadata.xml >/dev/null; done [1]
