559836 – don't run repo.postsync.d hooks on sync failure

Bug 559836 - don't run repo.postsync.d hooks on sync failure

Summary: don't run repo.postsync.d hooks on sync failure

Status:	CONFIRMED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Enhancement/Feature Requests (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-09-07 07:27 UTC by Ryan Hill (RETIRED)
Modified:	2015-09-07 07:27 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ryan Hill (RETIRED) gentoo-dev

2015-09-07 07:27:50 UTC

Currently if a repo fails to sync the repo.postsync.d hooks still get called.  Depending on what the hooks do this can leave things in an inconsistent state, or at the very least do some unnecessary work (eg. needlessly running egencache when nothing has changed).  I think it makes more sense to only run the hooks when the sync succeeds.