Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 559560 - sys-apps/elfix - paxmark.sh doesn't know how to handle make.conf as a folder
Summary: sys-apps/elfix - paxmark.sh doesn't know how to handle make.conf as a folder
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Hardened (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2015-09-03 21:37 UTC by James Le Cuirot
Modified: 2015-09-04 08:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch from git (0001-scripts-paxmark.sh-make.conf-can-be-a-directory.patch,1.02 KB, patch)
2015-09-03 21:37 UTC, James Le Cuirot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Le Cuirot gentoo-dev 2015-09-03 21:37:42 UTC
Created attachment 410956 [details, diff]
Patch from git

This feature was added to Portage back in 2013 but was only documented more recently. The problem was reported in bug #550312. See the attached patch.

P.S. While I'm on the subject, shouldn't the PAX_MARKINGS default mirror the eclass default, which is currently PT and XT rather than just PT? Or perhaps the USE flags should determine the default?
Comment 1 Anthony Basile gentoo-dev 2015-09-04 00:16:41 UTC
committed and i pushed out in elfix-0.9.1 which should be hitting the tree soon.  please test and reopen if this is an issue.

i didn't know make.conf could be a directory.
Comment 2 James Le Cuirot gentoo-dev 2015-09-04 08:53:52 UTC
(In reply to Anthony Basile from comment #1)
> committed and i pushed out in elfix-0.9.1 which should be hitting the tree
> soon.  please test and reopen if this is an issue.

Thanks for doing this so quickly but I kinda wish you hadn't! As I lay in bed, I suddenly thought "Crap, I should have just used portageq! Oh well, he probably won't look at it yet anyway."

PAX_MARKINGS=$(portageq envvar PAX_MARKINGS)

I'm sure you'll agree that's much nicer. I don't think that would rule out Paludis and the like as they seem to assume that Portage is also present.

By the way, I'd be very grateful if you could stop by #gentoo-java to answer a couple of questions about PaX stuff. We're having a little trouble.