The presented patch does fix the problem for GCC 3.4 I am sure. It however breaks builds based on gcc 3.3.3. So, the patch needs to be redone to have a #define in it so that the code change only takes place on 3.4 gcc versions. I was only able to get 1.3.1 to compile by commenting out the epatch line in the ebuild. Reproducible: Always Steps to Reproduce: 1. Ensure you have gcc 3.3.3 2. Emerge koffice 3. Actual Results: vcanvas.cc: In member function `void VCanvas::repaintAll(const KoRect&)': vcanvas.cc:314: error: request for member `x' in `this->rect', which is of non-aggregate type `<unknown type>' vcanvas.cc:314: error: request for member `y' in `this->rect', which is of non-aggregate type `<unknown type>' vcanvas.cc:314: error: request for member `width' in `this->rect', which is of non-aggregate type `<unknown type>' vcanvas.cc:314: error: request for member `height' in `this->rect', which is of non-aggregate type `<unknown type>' make[3]: *** [vcanvas.lo] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: Leaving directory `/var/tmp/portage/koffice-1.3.1-r1/work/koffice-1.3.1/karbon/widgets' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/var/tmp/portage/koffice-1.3.1-r1/work/koffice-1.3.1/karbon' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/koffice-1.3.1-r1/work/koffice-1.3.1' make: *** [all] Error 2 !!! ERROR: app-office/koffice-1.3.1-r1 failed. !!! Function kde_src_compile, Line 129, Exitcode 2 !!! died running emake, kde_src_compile:make Expected Results: This is realted to bug 50210. The fix for that bug was a patch that fixed koffice for gcc 3.4 and greater. Well, it breaks the builds where gcc <3.4 is used. I fixed it by removing the epatch line in the ebuild and all worked well. The patch needs to be redone to have some defines around the code change so that the code is only changed for gcc version 3.4 and higher.
I assume this old bug is not valid anymore.
