Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 559080 - =dev-python/scrapy-1.0.3 bump, test failures in file test_proxy_connect.py
Summary: =dev-python/scrapy-1.0.3 bump, test failures in file test_proxy_connect.py
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL: https://github.com/scrapy/scrapy/issu...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2015-08-29 10:27 UTC by Ian Delaney (RETIRED)
Modified: 2015-08-31 15:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Delaney (RETIRED) gentoo-dev 2015-08-29 10:27:35 UTC
On bumping this to -1.0.3 and adjusting deps, the second missed folder tests was added to the line py.test ${PN}.  This holds the bulk of the suite so prior to this the test phase was running only a handful of the written tests.

Under py2.7 only and with a plugin pytest-twisted installed locally, the suite persistently fails with:


===== 4 failed, 12 passed in 21.65 seconds =====

ProxyConnectTestCase.test_https_connect_tunnel
ProxyConnectTestCase.test_https_connect_tunnel_error
ProxyConnectTestCase.test_https_tunnel_auth_error
ProxyConnectTestCase.test_https_tunnel_without_leak_proxy_authorization_header

The full output is in the bug files upstream, no need to repeat it here.
Until this has a fix I see little point in:
1) adding the plugin to portage
2) bumping the package to -1.0.3. (1.0.2 is listed as the new release but the -1.0.3 was released just 4 days later) 

While 4 out of 1106 items is a good score, they still don't clear the package's new version. The prior versions never ran the tests folder so this was missed.
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2015-08-31 15:51:11 UTC
See comment by package owner in upstream issue 1464. We hope to see a fix in a next release

commit a34b4f77e0567f61197feba15f52a132a1064cf0
Author: Ian Delaney <idella4@gentoo.org>
Date:   Mon Aug 31 23:40:19 2015 +0800

    dev-python/scrapy: bump; update and tidy deps
    
    update test phase to run full testsuite, disable failing tests while
    upstream makes a fix, remove old