Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 558200 - dev-lang/go-1.5.0 new ebuild
Summary: dev-lang/go-1.5.0 new ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-19 19:25 UTC by user42
Modified: 2015-08-21 00:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description user42 2015-08-19 19:25:10 UTC
Go 1.5 was just released: http://blog.golang.org/go1.5

To build, it requires an existing installation of Go 1.4, which I noticed has been provided by dev-lang/go-bootstrap already.

Reproducible: Always




Here are the changes I made to get the ebuild to work. Now, I am by no means experienced at writing/maintaining ebuilds, but this should be a good starting point for someone who is:

--- /usr/portage/dev-lang/go/go-1.4.2.ebuild    2015-08-09 16:34:50.000000000 -0400
+++ go-1.5.ebuild       2015-08-19 15:20:32.647965206 -0400
@@ -24,7 +24,7 @@
 SLOT="0"
 IUSE=""
 
-DEPEND=""
+DEPEND="dev-lang/go-bootstrap"
 RDEPEND=""

 # These test data objects have writable/executable stacks.
@@ -45,15 +45,12 @@

 src_prepare()
 {
-       if [[ ${PV} != 9999 ]]; then
-               sed -i -e 's#"-Werror",##g' src/cmd/dist/build.c ||
-                       die "sed failed"
-       fi
        epatch_user
 }

 src_compile()
 {
+       export GOROOT_BOOTSTRAP="${EPREFIX}"/usr/lib/go1.4
        export GOROOT_FINAL="${EPREFIX}"/usr/lib/go
        export GOROOT="$(pwd)"
        export GOBIN="${GOROOT}/bin"
@@ -77,7 +74,7 @@
 src_install()
 {
        dobin bin/*
-       dodoc AUTHORS CONTRIBUTORS PATENTS README
+       dodoc AUTHORS CONTRIBUTORS CONTRIBUTING.md PATENTS README.md

        dodir /usr/lib/go
        insinto /usr/lib/go
@@ -86,7 +83,7 @@
        # Once this is fixed, we can consider using the doc use flag to control
        # installing the doc and src directories.
        # [1] https://golang.org/issue/2775
-       doins -r doc include lib pkg src
+       doins -r doc lib pkg src
        fperms -R +x /usr/lib/go/pkg/tool
 }
Comment 1 mike@marineau.org 2015-08-20 00:45:04 UTC
The existing live ebuild or my updated version in bug 558216 also work for 1.5. Those left out your addition of CONTRIBUTING.md though.
Comment 2 William Hubbs gentoo-dev 2015-08-21 00:40:06 UTC
This is now in the tree.

Thanks,

William