Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 557438 - x11-libs/qwt: Make dev-qt/designer dependency optional
Summary: x11-libs/qwt: Make dev-qt/designer dependency optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-13 10:30 UTC by Mira Ressel
Modified: 2015-09-07 18:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for x11-libs/qwt-6.1.2-r1 adding a USE flag for the designer plugin (qwt-6.1.2-r1-Build-Designer-plugin-conditionally.patch,1.93 KB, patch)
2015-09-07 15:43 UTC, Mira Ressel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mira Ressel 2015-08-13 10:30:42 UTC
Please make qwt's dependeny on QT Designer optional. QT designer is an development tool which shouldn't be required on user systems, and qwt only depends on it in order to install a Designer plugin.

It should be sufficient to remove the "QWT_CONFIG     += QwtDesigner" in qwtconfig.pri and adapt the corresponding lines in the ebuild. If wanted, I can try to provide a patch.
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2015-08-16 10:39:48 UTC
(In reply to Luis Ressel from comment #0)
> It should be sufficient to remove the "QWT_CONFIG     += QwtDesigner" in
> qwtconfig.pri and adapt the corresponding lines in the ebuild. If wanted, I
> can try to provide a patch.

Yes please, either provide a patch ehre or send a PR on github and highlight me directly.
Comment 2 Mira Ressel 2015-08-17 12:17:06 UTC
Okay, I'll prepare a patch. However, I'll probably not have any internet connectivity until early September, I'll upload it then. Sorry for the delay!
Comment 3 Mira Ressel 2015-09-07 15:43:06 UTC
Created attachment 411272 [details, diff]
Patch for x11-libs/qwt-6.1.2-r1 adding a USE flag for the designer plugin
Comment 4 Justin Lecher (RETIRED) gentoo-dev 2015-09-07 15:44:51 UTC
(In reply to Luis Ressel from comment #3)
> Created attachment 411272 [details, diff] [details, diff]
> Patch for x11-libs/qwt-6.1.2-r1 adding a USE flag for the designer plugin

Thanks for the patch. Could you please send a PR to our github repo and highlight me? I will merge it directly.
Comment 5 Mira Ressel 2015-09-07 17:05:01 UTC
Sorry, I can't access Github right now (I forgot my mobile with the 2FA codes at home). But my patch is in "git format-patch"-format, so you can easily apply it with "git am":

curl -L https://bugs.gentoo.org/attachment.cgi?id=411272 | git am -S<your GPG key id>
Comment 6 Justin Lecher (RETIRED) gentoo-dev 2015-09-07 18:09:15 UTC
commit d83a0e556a92ff2af5313b57ee6b6feb9237a841
Author: Luis Ressel <aranea@aixah.de>
Date:   Mon Sep 7 16:03:37 2015 +0200

    x11-libs/qwt: Build Designer plugin conditionally

    Thanks Luis Ressel for the patch

    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=557438

    Signed-off-by: Justin Lecher <jlec@gentoo.org>

    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d83a0e556a92ff2af5313b57ee6b6feb9237a841