Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 557176 - repo/gentoo.git: reject dumb 'git pull' merges
Summary: repo/gentoo.git: reject dumb 'git pull' merges
Status: CONFIRMED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Git (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Infrastructure
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-09 20:21 UTC by Michał Górny
Modified: 2019-08-25 08:03 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-08-09 20:21:36 UTC
I think we should add a git hook preventing committing of 'dumb' merges caused by 'git pull' on master. In other words, force people to either rebase or work on branches and merge those.

Maybe we can do this via checking commit ids on both parents. The easy & dumb way would be matching commit mesages for:

  Merge branch 'master' of git+ssh://git.gentoo.org/repo/gentoo

and likes.
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2016-03-14 01:26:07 UTC
dwfreed:
I've been wondering old bug about this in light of the right vs left parent discussion.

If we included a hook that forced merge parents to be correct, we'd also have to publish an official way of fixing anybody's rejected tree.

Any suggestions on doing so?