Hiya, The recent version bump of libgit2 to 0.23.0, causes libgit2-glib-0.22.8 to fail to compile: libtool: compile: x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -I. -pthread -I/usr/include/gobject-introspection-1.0 -I/usr/lib64/libffi-3.2.1/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include -DGIT_SSH=1 -Wall -O2 -march=native -pipe -c ggit-checkout-options.c -fPIC -DPIC -o .libs/ggit-checkout-options.o ggit-branch.c: In function 'ggit_branch_move': ggit-branch.c:105:8: error: too many arguments to function 'git_branch_move' ret = git_branch_move (&out, ^ In file included from /usr/include/git2.h:15:0, from ../libgit2-glib/ggit-ref.h:25, from ggit-branch.h:24, from ggit-branch.c:21: /usr/include/git2/branch.h:138:17: note: declared here GIT_EXTERN(int) git_branch_move( ^ Makefile:741: recipe for target 'ggit-branch.lo' failed make[3]: *** [ggit-branch.lo] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: Leaving directory '/var/tmp/portage/dev-libs/libgit2-glib-0.22.8/work/libgit2-glib-0.22.8/libgit2-glib' Makefile:577: recipe for target 'all' failed make[2]: *** [all] Error 2 make[2]: Leaving directory '/var/tmp/portage/dev-libs/libgit2-glib-0.22.8/work/libgit2-glib-0.22.8/libgit2-glib' Makefile:489: recipe for target 'all-recursive' failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory '/var/tmp/portage/dev-libs/libgit2-glib-0.22.8/work/libgit2-glib-0.22.8' Makefile:397: recipe for target 'all' failed make: *** [all] Error 2 * ERROR: dev-libs/libgit2-glib-0.22.8::gentoo failed (compile phase): * emake failed * * If you need support, post the output of `emerge --info '=dev-libs/libgit2-glib-0.22.8::gentoo'`, * the complete build log and the output of `emerge -pqv '=dev-libs/libgit2-glib-0.22.8::gentoo'`. * The complete build log is located at '/var/tmp/portage/dev-libs/libgit2-glib-0.22.8/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/dev-libs/libgit2-glib-0.22.8/temp/environment'. * Working directory: '/var/tmp/portage/dev-libs/libgit2-glib-0.22.8/work/libgit2-glib-0.22.8' * S: '/var/tmp/portage/dev-libs/libgit2-glib-0.22.8/work/libgit2-glib-0.22.8' Either libgit2-glib needs bumping (if possible) and/or the deps need changing to ensure it uses libgit2-0.22.* Given that libgit2's maintainer is devaway, and libgit2 and libgit2-glib need to be so closely linked, perhaps it would make sense to have them both maintained by the same maintainer, to avoid the numerous version mismatch bugs that get filed against them? (see bug 497410, bug 514628 and bug 536952)
This seems to be fixed upstream in upstream git master, but there are a *lot* of changes there making backporting difficult. I would prefer to wait for an official 0.23-compatible release. For now, I've given libgit-2-glib-0.22.x a dependency on <libgit2-0.23 + 26 Jul 2015; Alexandre Rostovtsev <tetromino@gentoo.org> + libgit2-glib-0.22.0.ebuild, libgit2-glib-0.22.8.ebuild: + Incompatible with libgit2-0.23 due to API changes (bug #555914, thanks to + Mike Auty).
https://git.gnome.org/browse/libgit2-glib/tag/?id=v0.23.0 libgit2-glib 0.23.0 has been released.
(In reply to Manuel Rüger from comment #2) > https://git.gnome.org/browse/libgit2-glib/tag/?id=v0.23.0 libgit2-glib > 0.23.0 has been released. It thoroughly breaks gitg :/ https://bugzilla.gnome.org/show_bug.cgi?id=752909
Getting the deps right on the existing package was the important part, the bumps can all wait until they're ready. Thanks very much! 5:)
The bumps are now ready, there's both 0.23.0, 0.23.2 and 0.23.4. Happy to open a separate bump bug, but not having the bump is quite annoying, since sometimes portage won't do a full "-avuDNt world" because it demands to update libgit2 and then can't.
Sorry, hadn't realized this was waiting on me. I've now changed the gitg deps for 3.16.1 to require >=libgit2-glib-0.22.0 and <libg2-glib-0.23.0. Since gitg now seems to be part of the main gnome repo, perhaps it should be looked after by the gnome herd? Happy to continue supporting it if the herd needs the help though...
yes, any help is appreciated. You can add gnome to the list of maintainers (but I think it's already the case) and keep on maintaining it as well.
It didn't have the herd listed, so I've added that now, thanks! 5:)
the versions in testing are ready for it
