Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 555900 - cmake-utils.eclass: please set default documentation directory
Summary: cmake-utils.eclass: please set default documentation directory
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2015-07-25 23:16 UTC by Andrew Savchenko
Modified: 2015-11-18 09:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
cmake-utils.eclass-docdir.patch (cmake-utils.eclass-docdir.patch,349 bytes, patch)
2015-07-25 23:16 UTC, Andrew Savchenko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Savchenko gentoo-dev 2015-07-25 23:16:08 UTC
Created attachment 407626 [details, diff]
cmake-utils.eclass-docdir.patch

Hello,

cmake allows to specify default docs installation directory (analogue of --docdir for configure script), but cmake-utils.eclass does nothing in this regard and many ebuilds in tree contain the same duplicated code:

-DCMAKE_INSTALL_DOCDIR=/usr/share/doc/${PF}

I propose to add this to the eclass, thus ebuilds can be simplified. See attached patch.
Comment 1 Johannes Huber (RETIRED) gentoo-dev 2015-07-26 08:48:27 UTC
It looks good to me but i would prefer if you send the patch to -dev ml to get a wider review.
Comment 2 Andrew Savchenko gentoo-dev 2015-07-26 09:49:02 UTC
Done.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2015-08-07 18:08:46 UTC
I responded on the mailing list why I disagree with the patch.
Comment 4 Michael Palimaka (kensington) gentoo-dev 2015-11-18 09:49:16 UTC
For the record, my response was as follows:

I count four packages using this option, with three different values
being passed. Use of CMAKE_INSTALL_DOCDIR is not standardised, and may
behave unpredictably between different packages.

As there were no further responses/discussion, I don't think we can proceed.