Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 555178 - app-shells/psh-1.8.1-r1 fails tests on perl-5.22 (Can't use 'defined(@array)' (Maybe you should just omit the defined()?)
Summary: app-shells/psh-1.8.1-r1 fails tests on perl-5.22 (Can't use 'defined(@array)'...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: https://rt.cpan.org/Ticket/Display.ht...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2015-07-17 10:14 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2015-12-03 17:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
psh-1.8.1-r2.ebuild (psh-1.8.1-r1.ebuild,840 bytes, text/plain)
2015-07-17 17:39 UTC, Kent Fredric (IRC: kent\n) (RETIRED) 		Details
files/defined-array.patch (defined-array.patch,291 bytes, patch)
2015-07-17 17:39 UTC, Kent Fredric (IRC: kent\n) (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2015-07-17 10:14:17 UTC 
/bi_tieopt.t .. 1/? 
#   Failed test 'use Psh::Builtins::Tieopt;'
#   at t/bi_tieopt.t line 19.
#     Tried to use 'Psh::Builtins::Tieopt'.
#     Error:  Can't use 'defined(@array)' (Maybe you should just omit the defined()?) at /tmp/portage/app-shells-psh-1.8.1-r1/work/psh-1.8.1/blib/lib/Psh.pm line 370.
# Compilation failed in require at /tmp/portage/app-shells-psh-1.8.1-r1/work/psh-1.8.1/blib/lib/Psh/Builtins/Tieopt.pm line 3.
# Compilation failed in require at t/bi_tieopt.t line 19.
# BEGIN failed--compilation aborted at t/bi_tieopt.t line 19.
   Failed test 'use Psh::Options;'
#   at t/bi_tieopt.t line 20.
#     Tried to use 'Psh::Options'.
#     Error:  Attempt to reload Psh.pm aborted.
# Compilation failed in require at /tmp/portage/app-shells-psh-1.8.1-r1/work/psh-1.8.1/blib/lib/Psh/Options.pm line 3.
# Compilation failed in require at t/bi_tieopt.t line 20.
# BEGIN failed--compilation aborted at t/bi_tieopt.t line 20.
Can't locate object method "TIESCALAR" via package "Psh::Support::TiedOption::Scalar" at /tmp/portage/app-shells-psh-1.8.1-r1/work/psh-1.8.1/blib/lib/Psh/Builtins/Tieopt.pm
 line 138.
# Looks like you failed 2 tests of 3.
# Looks like your test exited with 255 just after 3.
t/bi_tieopt.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/3 subtests
Comment 1 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2015-07-17 17:39:07 UTC 
Created attachment 407024 [details]
psh-1.8.1-r2.ebuild

-r2 ebuild because people who already installed it on 5.22 without running tests now have a broken install.
Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2015-07-17 17:39:51 UTC 
Created attachment 407026 [details, diff]
files/defined-array.patch
Comment 3 Pacho Ramos gentoo-dev 2015-11-08 12:29:26 UTC 
are you willing to proxy maintain this?
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Comment 4 Andreas K. Hüttel archtester gentoo-dev 2015-12-03 17:20:53 UTC 
commit f939882e96e9020835ec6d883a5a8e4e4e1ad971 (HEAD -> master, origin/master, origin/HEAD)
Author: Andreas K. Huettel (dilfridge) <dilfridge@gentoo.org>
Date:   Thu Dec 3 18:19:39 2015 +0100

    app-shells/psh: Add compatibility patch for Perl 5.22; other QA cleanups
    
    Package-Manager: portage-2.2.26

 app-shells/psh/files/psh-1.8.1-defined-array.patch | 11 +++++++++++
 app-shells/psh/psh-1.8.1-r1.ebuild                 |  7 ++++---
 app-shells/psh/psh-1.8.1-r2.ebuild                 | 38 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 53 insertions(+), 3 deletions(-)