Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 555132 - sys-devel/llvm-9999: llvm-3.5-gcc-4.9.patch causes compile to fail and is unneeded
Summary: sys-devel/llvm-9999: llvm-3.5-gcc-4.9.patch causes compile to fail and is unn...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-17 02:32 UTC by Nick Sarnie
Modified: 2015-07-19 17:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
compile error with patch (compile error,3.46 KB, text/plain)
2015-07-17 02:33 UTC, Nick Sarnie
Details
New version of llvm-3.7-gcc-4.9.patch (llvm-3.7-gcc-4.9.patch,1.65 KB, patch)
2015-07-18 21:10 UTC, Bigos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sarnie gentoo-dev 2015-07-17 02:32:42 UTC
Hi. If I try to compile llvm-9999, it fails because of llvm-3.5-gcc-4.9.patch with a compile error. I removed the patch and tried it in a local overlay, and LLVM compiles and works fine. I am on GCC 4.9.3.


Thanks,
sarnex

Reproducible: Always
Comment 1 Nick Sarnie gentoo-dev 2015-07-17 02:33:23 UTC
Created attachment 406960 [details]
compile error with patch
Comment 2 Bigos 2015-07-18 21:10:13 UTC
Created attachment 407102 [details, diff]
New version of llvm-3.7-gcc-4.9.patch

Here is a new version of the problematic patch. This or maybe it could be dropped entirely (as sarnex said before). Like the name of this patch implies, it is a newer version of the previous patch for llvm 3.7 and above.

Also, for llvm-9999.ebuild to work, the CLANG_VERSION variable should be changed from 3.7 to 3.8 in the ebuild file, since llvm trunk is now 3.8.
Comment 3 Nick Sarnie gentoo-dev 2015-07-18 21:38:09 UTC
(In reply to Bigos from comment #2)
> Created attachment 407102 [details, diff] [details, diff]
> New version of llvm-3.7-gcc-4.9.patch
> 
> Here is a new version of the problematic patch. This or maybe it could be
> dropped entirely (as sarnex said before). Like the name of this patch
> implies, it is a newer version of the previous patch for llvm 3.7 and above.
> 
> Also, for llvm-9999.ebuild to work, the CLANG_VERSION variable should be
> changed from 3.7 to 3.8 in the ebuild file, since llvm trunk is now 3.8.

Hi,

Thanks for your patch. LLVM compiles and works fine for me with this patch. I cannot reproduce the problem the original patch was trying to fix, so I can't comment if it still fixes that issue. 

Hopefully this gets sorted soon,

sarnex
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-07-19 17:29:45 UTC
Thanks for your work, Bigos but since we can't reproduce the issue with gcc-4.9, I'm going to assume it was fixed upstream and the patch is no longer necessary.

+  19 Jul 2015; Michał Górny <mgorny@gentoo.org> llvm-9999.ebuild:
+  Remove no longer needed gcc-4.9 patch. Update clang vesion number.