Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 554926 - dev-perl/Eval-Closure-0.130.0 version bump. ( 0.80.0-r1 fails tests on perl 5.22 )
Summary: dev-perl/Eval-Closure-0.130.0 version bump. ( 0.80.0-r1 fails tests on perl 5...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Perl team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-15 05:33 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2015-07-17 10:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Eval-Closure-0.130.0.ebuild (Eval-Closure-0.130.0.ebuild,863 bytes, text/plain)
2015-07-15 05:33 UTC, Kent Fredric (IRC: kent\n) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2015-07-15 05:33:05 UTC
Created attachment 406824 [details]
Eval-Closure-0.130.0.ebuild

PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/00-compile.t ............ ok   
t/basic.t ................. ok   
t/canonicalize-source.t ... ok   
t/close-over.t ............ 1/? 
#   Failed test 'visible list is sane'
#   at t/close-over.t line 56.
# Looks like you failed 1 test of 3.
t/close-over.t ............ Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 


- https://github.com/doy/eval-closure/issues/6
- https://github.com/doy/eval-closure/issues/5
- https://github.com/doy/eval-closure/issues/4

These issues should be fixed in 0.130.0 ( 0.13 )

https://metacpan.org/source/DOY/Eval-Closure-0.13/Changes#L3

I have attached a modified ebuild, which has a few substantial changes:

- No longer needs Sub::Exporter
- More explicit use of some virtuals ( with a comment about Scalar::Util because it *will* be a problem in the near future )
- Test::Output is no longer required for testing

Additionally, upstream have some "Runtime recommends" values, which turn out to be used in actual features:

- https://metacpan.org/source/DOY/Eval-Closure-0.13/META.json#L34

An "alias" parameter requires Devel::LexAlias:
- https://metacpan.org/source/DOY/Eval-Closure-0.13/lib/Eval/Closure.pm#L124
- https://metacpan.org/source/DOY/Eval-Closure-0.13/lib/Eval/Closure.pm#L278

And "Dump source" try's to use Perl::Tidy where possible:
- https://metacpan.org/source/DOY/Eval-Closure-0.13/lib/Eval/Closure.pm#L185

As such, both of these dependencies are in by default, and they can be excluded with USE="minimal"

However, these require dropping ~arm ~hppa ~ppc64 keywords:

perltidy is not ~arm or ~hppa
Devel-LexAlias is not ~ppc64 or ~hppa
Comment 1 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2015-07-17 10:39:23 UTC
Do _NOT_ drop keywords on bumps :)