Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 554752 - app-arch/star-1.5.3: star-1.5.1-changewarnSegv.patch introduces a QA warning
Summary: app-arch/star-1.5.3: star-1.5.1-changewarnSegv.patch introduces a QA warning
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Shell Tools project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-13 14:18 UTC by Toralf Förster
Modified: 2015-07-27 13:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2015-07-13 14:18:49 UTC
I reported a QA warning to upstream. The answer is below (and correct in my eyes - the QA issue is introduced by the Gentoo patch file).




Toralf Förster <toralf.foerster@gmx.de> wrote:

> At a stable Gentoo I do get :
>
>
> * Messages for package app-arch/star-1.5.3:
>
>  * QA Notice: Package triggers severe warnings which indicate that it
>  *            may exhibit random runtime failures.
>  * checkerr.c:212:5: warning: incompatible implicit declaration of built-in function 'free'
>  * checkerr.c:218:3: warning: incompatible implicit declaration of built-in function 'free'
>  * Please do not file a Gentoo bug and instead report the above QA
>  * issues directly to the upstream developers of this software.
>  * Homepage: http://s-tar.sourceforge.net/
>>>> Auto-cleaning packages...

It seems that you are either not compiling star-1.5.3 or using a broken compiler.

The whole files does not include the text "free" at all".

In special, line 212:

	        } while (p < ef && p && *p++ == '|');

and line 218:

		}
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2015-07-27 13:09:08 UTC
+  27 Jul 2015; Justin Lecher <jlec@gentoo.org> star-1.5.3.ebuild:
+  Drop unneeded patch as upstream author complaint about it
+