Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 554556 - <dev-qt/qtnetwork-5.6 does not build against musl
Summary: <dev-qt/qtnetwork-5.6 does not build against musl
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH, UPSTREAM
: 557960 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-07-11 21:23 UTC by Vic Kerr (wikky)
Modified: 2015-12-25 18:30 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add dev-qt/qtnetwork to ::musl (0001-dev-qt-qtnetwork-Fix-socklen_t-detection.-Bug-554556.patch,8.34 KB, patch)
2015-07-11 21:27 UTC, Vic Kerr (wikky) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vic Kerr (wikky) 2015-07-11 21:23:43 UTC 
dev-qt/qtnetwork does not compile against musl for the same reason as in bug 551640. Turns out the fix has not made its way to upstream like I thought it did.

Interestingly, dev-qt/qtcore:5 builds fine, despite both being built from the same source tarball.
Comment 1 Vic Kerr (wikky) 2015-07-11 21:27:40 UTC 
Created attachment 406568 [details, diff]
Add dev-qt/qtnetwork to ::musl
Comment 2 Vic Kerr (wikky) 2015-07-11 21:28:13 UTC 
This should definitely make its way upstream.
Comment 3 Davide Pesavento (RETIRED) gentoo-dev 2015-07-13 17:05:24 UTC 
I'm confused by what is stated in the other bug... was the patch ever submitted upstream via gerrit?
Comment 4 Vic Kerr (wikky) 2015-07-13 17:41:58 UTC 
(In reply to Davide Pesavento from comment #3)
> I'm confused by what is stated in the other bug... was the patch ever
> submitted upstream via gerrit?

No. I was mislead by qtcore:5 building fine.
Comment 5 Davide Pesavento (RETIRED) gentoo-dev 2015-07-13 17:47:17 UTC 
I see. Can you please submit it then? You have to use gerrit: https://codereview.qt-project.org/ either the 'dev' or the '5.5' branch.
Comment 6 Davide Pesavento (RETIRED) gentoo-dev 2015-08-18 13:41:53 UTC 
*** Bug 557960 has been marked as a duplicate of this bug. ***
Comment 8 Davide Pesavento (RETIRED) gentoo-dev 2015-10-01 02:04:23 UTC 
Merged. Thanks for your hard work!
Comment 9 tt_1 2015-12-25 10:35:17 UTC 
would it be possible to add the backported patch to the in-tree qtnetwork-5.4.2 as well? cause it is as well affected.
Comment 10 Davide Pesavento (RETIRED) gentoo-dev 2015-12-25 16:44:57 UTC 
5.4.2 is the current stable and I'd rather avoid touching it. 5.5.1, which has the backported patch, is going stable very soon.
Comment 11 Anthony Basile gentoo-dev 2015-12-25 18:30:33 UTC 
(In reply to tt_1 from comment #9)
> would it be possible to add the backported patch to the in-tree
> qtnetwork-5.4.2 as well? cause it is as well affected.

(In reply to Davide Pesavento from comment #10)
> 5.4.2 is the current stable and I'd rather avoid touching it. 5.5.1, which
> has the backported patch, is going stable very soon.

We can wait.  I could backport it in the musl overlay, or one can just unmask qtnetwork-5.5.1, so no need to backport in the tree.

On a side note, I'm impressed on how well the gentoo community has accepted musl as a substitute for glibc.  We are one of the first distros to do so and now we can build entire desktop systems with musl.  Given musl's adherence to POSIX, XOPEN and other standards, we have become an serious impetus in cleaning up many upstream coding standards.  Merry xmas.