Currently the only USE flag is minimal, which - after taking a look into the code just enables (amalloc) DEBUG! Reproducible: Always Steps to Reproduce: 1. env 'EXTRA_ECONF=--with-dl=Both --with-id-anchor --with-github-tags --with-fenced-code' emerge -1 discount Expected Results: Get a library with following version string: "2.1.6 DL=BOTH ID-ANCHOR GITHUB-TAGS FENCED-CODE"
Created attachment 406534 [details] ebuild using EXTRA_ECONF
I’m not sure supporting `EXTRA_ECONF` would be the right thing. discount provides ./configure.sh, not ./configure. That is the reason I am not calling econf() in the first place. I guess that make.conf(5) doesn’t really say that `EXTRA_ECONF` is intended only for autoconf-compatible ./configure scripts, but the package manager specifications state that econf() is only intended for autoconf-compatible ./configure script. So, I am going to consider `EXTRA_ECONF` as only intended to be relevant for when econf() is relevant. Because you need the finer-grained control over building discount, I’m fine with having the ebuild respect something like `DISCOUNT_EXTRA_CONFIGURE_SH`. Also, I will look at exposing some of the options as useflags, though I’m not sure how well that would work out. Ideally, all of these options would be controllable at runtime through the existing flags mechanism. But it looks like some features and settings can only be changed at compile time, meaning that if you need to support different syntaxes on the same machine you’d need a way to install those different configurations simultaneously. So the solution that makes the most sense to me would be for upstream to move functionality-related configuration from compiletime to runtime… https://github.com/Orc/discount/issues/124 . So, I’ll add `DISCOUNT_EXTRA_CONFIGURE_SH` for now when I bump it to 2.1.8a.
My ideas to use ECONF_EXTRA was, because it is more known to the average Gentoo user, but the specialities of the build system of discount aren't. But I can live with it :D It would be nice to print out an elog if DISCOUNT_EXTRA_CONFIGURE_SH isn't set, to point the user to that option.
I’ve committed app-text/discount-2.1.8a as unstable. It has `DISCOUNT_EXTRA_CONFIGURE_SH`. However, looks like upstream is fine with making all of these compiletime configuration options runtime https://github.com/Orc/discount/issues/124#issuecomment-120682042 , so this method of configuring discount should disappear next release if that works out.
(In reply to Heiko Schäfer from comment #3) > My ideas to use ECONF_EXTRA was, because it is more known to the average > Gentoo user, but the specialities of the build system of discount aren't. > But I can live with it :D > > It would be nice to print out an elog if DISCOUNT_EXTRA_CONFIGURE_SH isn't > set, to point the user to that option. I bet that by the time the user has decided they want to pass non-standard flags to ./configure.sh, they’ll already have looked at the ebuild. But maybe that is just me and not the normal discount user ;-). Anyways, hopefully this will all go away soon, but I’ll add that elog you requested.
(In reply to Nathan Phillip Brink (binki) from comment #5) > I bet that by the time the user has decided they want to pass non-standard > flags to ./configure.sh, they’ll already have looked at the ebuild. But > maybe that is just me and not the normal discount user ;-). Anyways, > hopefully this will all go away soon, but I’ll add that elog you requested. I'm testified in non-comformant thinking, so don't worry it is surely not only you :D I'll test it later, because I have a build in my developer VM and cannot start the Gentoo-VM atm.
(In reply to Heiko Schäfer from comment #6) > (In reply to Nathan Phillip Brink (binki) from comment #5) > > I bet that by the time the user has decided they want to pass non-standard > > flags to ./configure.sh, they’ll already have looked at the ebuild. But > > maybe that is just me and not the normal discount user ;-). Anyways, > > hopefully this will all go away soon, but I’ll add that elog you requested. > > I'm testified in non-comformant thinking, so don't worry it is surely not > only you :D > > I'll test it later, because I have a build in my developer VM and cannot > start the Gentoo-VM atm. Works with charm :D IMO you can close this bug as resolved fied.
Since you’re happy, I guess I’ll close this bug then. I was going to leave it IN_PROGRESS until it was stabilized… but I don’t know what I’m doing anyway. In case you want to start porting your code to how discount will handle this in the future, see and/or subscribe to https://github.com/Orc/discount/pull/125 . I’m excited to be able to remove this DISCOUNT_EXTRA_CONFIGURE_SH whenever the next release is :-p. Oh, and a side note, it would be much more helpful to me if you had attached a unified diff to this bug rather than the full ebuild when suggesting changes. When small changes happen to the ebuild in tree, it takes more work to find what you changed. I’m not just going to copy a full ebuild dump from bugzilla into the tree because it might undo other fixes, etc. Not that that happened this time or anything. Just sayin’.
