Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 55420 - Additional flag for xine-lib -- please add
Summary: Additional flag for xine-lib -- please add
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High trivial (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-28 06:58 UTC by Joël
Modified: 2004-06-29 12:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Output of emerge info (upupa,2.02 KB, text/plain)
2004-06-29 12:05 UTC, Joël
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joël 2004-06-28 06:58:16 UTC
Here's a line that I'd suggest for addition to xine-lib-1_rc5.ebuild:

filter-flags -funroll-all-loops

This fixes the build failure which happens when -funroll-all-loops is in the CFLAGS.

Replacing it with -funroll-loops also works well.

Thanks
Comment 1 Chris White (RETIRED) gentoo-dev 2004-06-28 08:18:52 UTC
Assigning to media-video herd.  I'll talk with them about it at some point :).
Comment 2 Brian Harring (RETIRED) gentoo-dev 2004-06-28 11:02:42 UTC
Please add the output from emerge info, and tag on a log of it bombing out w/ -funroll-all-loops.

The reason I ask, is that at first glance, there is no way to tell if this is purely -funroll-all-loops related, or related to your particular combination of cflags applied to xine-lib.
Comment 3 Martin Holzer (RETIRED) gentoo-dev 2004-06-28 13:48:13 UTC
xine itself adds -funroll-loops to cflags
Comment 4 Joël 2004-06-29 12:05:02 UTC
Created attachment 34438 [details]
Output of emerge info
Comment 5 Joël 2004-06-29 12:08:05 UTC
Hi Brian,

I've attached the output of emerge info. As you see, I also tried with just "-pipe -O2 -funroll-all-loops" and it failed too. The original CFLAGS are heavy: "-pipe -O3 -march=pentium4 -mmmx -msse -msse2 -mfpmath=sse,387 -maccumulate-outgoing-args -mno-align-stringops -fomit-frame-pointer -ffast-math -funroll-all-loops -fsched-spec-load -fprefetch-loop-arrays -ftracer -fmove-all-movables --param max-gcse-passes=4"

Here's the last few lines of the log (built with -pipe -O2 -funroll-all-loops):

 gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -I../../.. -I../../../include -I../../../include -I../../../src -I../../../src/xine-engine -I../../../src/xine-engine -I../../../src/xine-utils -I../../../src/input -I../../../src/input -DHAVE_MMX -falign-functions=4 -falign-loops=4 -falign-jumps=4 -mpreferred-stack-boundary=2 -fschedule-insns2 -fno-strict-aliasing -Wall -DNDEBUG -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DXINE_COMPILE -Wpointer-arith -Wnested-externs -Wcast-align -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -pipe -O2 -funroll-all-loops -fno-stack-protector -mno-sse2 -MT ifs_display.lo -MD -MP -MF .deps/ifs_display.Tpo -c ifs_display.c -o .libs/ifs_display.o
ifs_display.c: In function `ifs_update':
ifs_display.c:62: error: invalid `asm': invalid constraints for operand
ifs_display.c:64: error: invalid `asm': invalid constraints for operand
ifs_display.c:62: error: invalid `asm': invalid constraints for operand
ifs_display.c:64: error: invalid `asm': invalid constraints for operand
ifs_display.c:62: error: invalid `asm': invalid constraints for operand
ifs_display.c:64: error: invalid `asm': invalid constraints for operand
ifs_display.c:62: error: invalid `asm': invalid constraints for operand
ifs_display.c:64: error: invalid `asm': invalid constraints for operand
{standard input}: Assembler messages:
{standard input}:109: Error: expecting operand before ','; got nothing
{standard input}:114: Error: expecting operand after ','; got nothing
{standard input}:136: Error: expecting operand before ','; got nothing
{standard input}:141: Error: expecting operand after ','; got nothing
{standard input}:163: Error: expecting operand before ','; got nothing
{standard input}:168: Error: expecting operand after ','; got nothing
{standard input}:190: Error: expecting operand before ','; got nothing
{standard input}:195: Error: expecting operand after ','; got nothing
make[4]: *** [ifs_display.lo] Error 1
make[4]: Leaving directory `/var/tmp/portage/xine-lib-1_rc5-r2/work/xine-lib-1-rc5/src/post/goom'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/var/tmp/portage/xine-lib-1_rc5-r2/work/xine-lib-1-rc5/src/post'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/xine-lib-1_rc5-r2/work/xine-lib-1-rc5/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/xine-lib-1_rc5-r2/work/xine-lib-1-rc5'
make: *** [all] Error 2

!!! ERROR: media-libs/xine-lib-1_rc5-r2 failed.
!!! Function src_compile, Line 124, Exitcode 2
!!! Parallel make failed
Comment 6 SpanKY gentoo-dev 2004-06-29 12:22:59 UTC
done