Bug 554108 – sys-apps/portage-2.2.20: FEATURES=cgroup is vulnerable interference between parallel builds of the same ${CATEGORY}:${PF}

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Zac Medico 2015-07-07 00:42:09 UTC]

The vulnerable code in AbstractEbuildProcess is as follows:

    cgroup_path = os.path.join(cgroup_portage,
            '%s:%s' % (self.settings["CATEGORY"],
                self.settings["PF"]))

Instead, we should use tempfile.mkdtemp or something similar.

[Comment 1 Brian Dolbec (RETIRED) 2015-07-07 01:02:05 UTC]

sounds good to me :)

[Comment 2 Zac Medico 2015-07-07 05:09:08 UTC]

The number of temp dirs that we will create is unlimited, so we need to ensure that they are promptly destroyed. We can unshare the mount namespace and make /sys/fs/cgroup/portage a private mount which will automatically disappear when portage exits.

[Comment 3 Zac Medico 2015-07-07 07:31:58 UTC]

There's a patch in the following branch:

https://github.com/zmedico/portage/tree/bug_554108

I've posted it for review here:

https://archives.gentoo.org/gentoo-portage-dev/message/86f2105d445897c3690df7856371093f

[Comment 4 Zac Medico 2015-07-07 18:39:08 UTC]

This is in the master branch:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=551837f0de95cf8e3e741e76094b31cfc0d68bd5

[Comment 5 Brian Dolbec (RETIRED) 2015-09-22 01:22:39 UTC]

Released in portage-2.2.21