Bug 553746 – games-strategy/s25rttr-0.8.1 : : CMakeFiles/videoSDL.dir/SDL.cpp.o: relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Toralf Förster 2015-07-01 20:39:33 UTC]

Created attachment 406042 [details]
emerge log

/usr/bin/x86_64-pc-linux-gnu-g++   -march=native -O2 -pipe  -I/var/tmp/portage/games-strategy/s25rttr-0.8.1/work/s25rttr-0.8.1_build -I/usr/include/SDL  -Wl,-O1 -Wl,--as-needed -shared -Wl,-soname,libvideoSDL.so -o libvideoSDL.so CMakeFiles/videoSDL.dir/SDL.cpp.o CMakeFiles/videoSDL.dir/__/__/__/__/build_version.cpp.o CMakeFiles/videoSDL.dir/__/__/__/src/DriverInterface.cpp.o  -L/var/tmp/portage/games-strategy/s25rttr-0.8.1/work/s25rttr-0.8.1_build/driver/src ../../../src/libvideodrv.a -Wl,-Bstatic -lSDLmain -Wl,-Bdynamic -lSDL -lpthread 
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.2/../../../../x86_64-pc-linux-gnu/bin/ld: CMakeFiles/videoSDL.dir/SDL.cpp.o: relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
CMakeFiles/videoSDL.dir/SDL.cpp.o: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
driver/video/SDL/src/CMakeFiles/videoSDL.dir/build.make:139: recipe for target 'driver/video/SDL/src/libvideoSDL.so' failed
make[2]: *** [driver/video/SDL/src/libvideoSDL.so] Error 1
make[2]: Leaving directory '/var/tmp/portage/games-strategy/s25rttr-0.8.1/work/s25rttr-0.8.1_build'
CMakeFiles/Makefile2:246: recipe for target 'driver/video/SDL/src/CMakeFiles/videoSDL.dir/all' failed
make[1]: *** [driver/video/SDL/src/CMakeFiles/videoSDL.dir/all] Error 2
make[1]: Leaving directory '/var/tmp/portage/games-strategy/s25rttr-0.8.1/work/s25rttr-0.8.1_build'
Makefile:116: recipe for target 'all' failed
make: *** [all] Error 2
 * ERROR: games-strategy/s25rttr-0.8.1::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=games-strategy/s25rttr-0.8.1::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=games-strategy/s25rttr-0.8.1::gentoo'`.
 * The complete build log is located at '/var/log/portage/games-strategy:s25rttr-0.8.1:20150701-203009.log'.
 * For convenience, a symlink to the build log is located at '/var/tmp/portage/games-strategy/s25rttr-0.8.1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/games-strategy/s25rttr-0.8.1/temp/environment'.
 * Working directory: '/var/tmp/portage/games-strategy/s25rttr-0.8.1/work/s25rttr-0.8.1_build'
 * S: '/var/tmp/portage/games-strategy/s25rttr-0.8.1/work/s25rttr-0.8.1'

  -----------------------------------------------------------------

  This is an unstable amd64 chroot image (named amd64-unstable_20150621-132035) at a hardened host acting as a tinderbox.

Portage 2.2.20 (python 2.7.10-final-0, default/linux/amd64/13.0/desktop/kde, gcc-4.9.2, glibc-2.20-r2, 4.0.6-hardened-r2 x86_64)
=================================================================
System uname: Linux-4.0.6-hardened-r2-x86_64-Intel-R-_Core-TM-_i7-3770_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem:    16164692 total,   1198684 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Wed, 01 Jul 2015 15:45:01 +0000
sh bash 4.3_p39
ld GNU ld (Gentoo 2.25 p1.2) 2.25
distcc 3.2rc1 x86_64-pc-linux-gnu [disabled]
ccache version 3.2.2 [disabled]
app-shells/bash:          4.3_p39::gentoo
dev-java/java-config:     2.2.0::gentoo
dev-lang/perl:            5.22.0::gentoo
dev-lang/python:          2.7.10::gentoo, 3.3.5-r1::gentoo
dev-util/ccache:          3.2.2::gentoo
dev-util/cmake:           3.2.3::gentoo
dev-util/pkgconfig:       0.28-r3::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.17::gentoo
sys-apps/sandbox:         2.6-r1::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r1::gentoo
sys-devel/automake:       1.9.6-r4::gentoo, 1.10.3-r1::gentoo, 1.11.6-r1::gentoo, 1.13.4::gentoo, 1.14.1::gentoo, 1.15::gentoo
sys-devel/binutils:       2.25-r1::gentoo
sys-devel/gcc:            4.8.4::gentoo, 4.9.2::gentoo
sys-devel/gcc-config:     1.8::gentoo
sys-devel/libtool:        2.4.6-r1::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 4.0::gentoo (virtual/os-headers)
sys-libs/glibc:           2.20-r2::gentoo
Repositories:

local
    location: /usr/local/portage
    masters: gentoo

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: 9999

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /etc/entropy /etc/stunnel/stunnel.conf /opt/openfire/resources/security/ /usr/lib64/fax /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt /var/lib/hsqldb /var/lib/i2pd/certificates /var/spool/fax/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.5/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/var/tmp/distfiles"
EMERGE_DEFAULT_OPTS="--nospinner --tree --quiet-build"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo rsync://mirror.netcologne.de/gentoo/ ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gor.bytemark.co.uk/gentoo/ rsync://ftp.snt.utwente.nl/gentoo"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi aes-ni alsa amd64 apache2 avx avx2 berkdb bluetooth branding btrfs bzip2 cairo cdda cdr cli consolekit corefonts cracklib crypt cups cxx dbus declarative designer dnssec dot dri drmkms dts dvd dvdr ecc emboss encode exif extraengine fam ffmpeg firefox flac fontconfig fortran fpm gd gdbm gif glamor gpm gtk gudev gui iconv icu ipv6 isag jadetex jpeg kde kipi kvm lapack lcms libkms libnotify libvirtd logrotate mad mbox minizip mmx mmxext mng modules mp3 mp4 mpeg multilib mysql ncurses nls nptl ogg opengl openmp openssl pam pango pax_kernel pcre pcre16 pdf phonon plasma png policykit ppds pwquality python qemu qt3support qt4 qz5 readline scrpyt sdl session spell spice sqlite sse sse2 sse4 sse4_1 sse4_2 ssh-askpass ssl ssse3 startup-notification svg tcl tcpd theora thinkpad threads tiff tk tls truetype udev udisks uml unicode upower usb usbredir uxa v4l v4l2 video vorbis wxwidgets x264 xa xcb xcomposite xinerama xkb xml xmp xscreensaver xslt xv xvfb xvid xvmc zenmap zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk330 1 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_GB" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

[Comment 1 Toralf Förster 2015-07-01 20:39:54 UTC]

Created attachment 406044 [details]
package history

[Comment 2 tt_1 2015-09-17 19:32:31 UTC]

Created attachment 412114 [details, diff]
cflags patch

this is a patch for the ebuild. try if it works for you.

[Comment 3 tt_1 2015-09-18 15:24:17 UTC]

Created attachment 412166 [details, diff]
c-flas patch for cmake

this patch changes the c-flags respectively for the affected library only.

[Comment 4 Toralf Förster 2015-09-19 15:37:42 UTC]

Hhm,

etc/portage/patches/games-strategy/s25rttr/reloc.patch


is ignored :-(

[Comment 5 abandoned account disabled email 2015-09-19 15:46:46 UTC]

Apparently because src_prepare is lacking a call to epatch_user
in /usr/portage/games-strategy/s25rttr/s25rttr-0.8.1.ebuild

Example of another packages which has it: /usr/portage/games-strategy/seven-kingdoms/seven-kingdoms-2.14.5.ebuild

Cheers

[Comment 6 tt_1 2015-09-19 16:20:19 UTC]

the first proposed patch is for the ebuild itself and changes the applied cflags, it adds -fPIC to be more precise. it has to be copied into the folder where your s25rttr-0.8.1 ebuild is located and to be applied by patch -p2 < name-of-patch-file + ebuild s25rttr-0.8.1.ebuild manifest to regenerate the checksums. 

the second patch adds the demanded cflags -fPIC to the audio and the video driver only, not for the whole package. it has to be copied into the files dir inside of your s25rttr directory, plus src_prepare section of the ebuild has to be modified like this. 


src_prepare() {
	epatch "${FILESDIR}"/${P}-cmake.patch \
		"${FILESDIR}"/${P}-soundconverter.patch \
		"${FILESDIR}"/name-of-patch-file.patch 
}

[Comment 7 Julian Ospald 2015-09-19 17:24:25 UTC]

(In reply to Toralf Förster from comment #4)
> Hhm,
> 
> etc/portage/patches/games-strategy/s25rttr/reloc.patch
> 
> 
> is ignored :-(

epatch_user is broken nonesense and should be removed. You want to make your own hooks for reliable user patches

for portage see: https://wiki.gentoo.org/wiki//etc/portage/patches#Enabling_.2Fetc.2Fportage.2Fpatches_for_all_ebuilds
for paludis see: https://zaufi.github.io/my-paludis-hooks-and-addons.html

[Comment 8 abandoned account disabled email 2015-09-19 18:05:25 UTC]

(In reply to Julian Ospald (hasufell) from comment #7)
> (In reply to Toralf Förster from comment #4)
> > Hhm,
> > 
> > etc/portage/patches/games-strategy/s25rttr/reloc.patch
> > 
> > 
> > is ignored :-(
> 
> epatch_user is broken nonesense and should be removed. You want to make your
> own hooks for reliable user patches
> 
> for portage see:
> https://wiki.gentoo.org/wiki//etc/portage/patches#Enabling_.2Fetc.2Fportage.
> 2Fpatches_for_all_ebuilds
> for paludis see: https://zaufi.github.io/my-paludis-hooks-and-addons.html

Very useful! Exactly what I needed. Thank you kindly.

[Comment 9 tt_1 2015-10-05 18:48:04 UTC]

could someone, e.g. the maintainer of this package, please push out a -r1 with the in given sdl-patch in comment #3?

[Comment 10 Mr. Bones. (RETIRED) 2015-10-06 22:53:50 UTC]

in portage.  thanks for the patch.

[Comment 11 Julian Ospald 2016-01-14 22:11:02 UTC]

the patch is incomplete

[Comment 12 Mr. Bones. (RETIRED) 2016-04-20 18:44:03 UTC]

seems to build.  I guess further enhancements can go in a new bug.