Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 552598 - app-office/texmaker with QT5 can't set style in Modern Interface
Summary: app-office/texmaker with QT5 can't set style in Modern Interface
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Justin Lecher (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-20 00:04 UTC by jorgicio
Modified: 2015-06-24 06:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch that fixes the Style settings (texmaker-modern-styles.patch,658 bytes, patch)
2015-06-20 00:05 UTC, jorgicio
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jorgicio 2015-06-20 00:04:47 UTC
Hi!

Texmaker, with QT5 support, cannot allow to set the style. It always uses Fusion by default, so I'll attach a patch made by me that fixes that. I just tested it, and working.

Reproducible: Always
Comment 1 jorgicio 2015-06-20 00:05:21 UTC
Created attachment 405388 [details, diff]
Patch that fixes the Style settings
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2015-06-21 10:48:58 UTC
Could you please file a bug upstream with this patch and add the url here?

I would like to hear what upstream says.

https://code.google.com/p/texmaker/issues
Comment 3 jorgicio 2015-06-21 14:39:23 UTC
(In reply to Justin Lecher from comment #2)
> Could you please file a bug upstream with this patch and add the url here?
> 
> I would like to hear what upstream says.
> 
> https://code.google.com/p/texmaker/issues

As I see, it's a little bit abandoned, and a few projects still use the Google Code to file issues (which is not bad). Anyway, I reported there, but I don't know how long it takes to solve. I can't assure that.

Meanwhile, a patch is not bad.
Comment 4 jorgicio 2015-06-21 20:52:44 UTC
Yes, I reported that issue, just in case only.
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2015-06-22 07:39:30 UTC
(In reply to jorgicio from comment #4)
> Yes, I reported that issue, just in case only.

yes, I know. I just added the reference here.

How can I test the functionality of the patch?
Comment 6 jorgicio 2015-06-22 17:08:21 UTC
(In reply to Justin Lecher from comment #5)
> (In reply to jorgicio from comment #4)
> > Yes, I reported that issue, just in case only.
> 
> yes, I know. I just added the reference here.
> 
> How can I test the functionality of the patch?

After patch applied and compiled manually with the ebuild (and installed the respective package), just set the style as an environment variable, or run it from terminal with the style you want passed as a parameter.

e.g.

texmaker -style gtk
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2015-06-23 06:27:09 UTC
(In reply to jorgicio from comment #6)
> (In reply to Justin Lecher from comment #5)
> > (In reply to jorgicio from comment #4)
> > > Yes, I reported that issue, just in case only.
> > 
> > yes, I know. I just added the reference here.
> > 
> > How can I test the functionality of the patch?
> 
> After patch applied and compiled manually with the ebuild (and installed the
> respective package), just set the style as an environment variable, or run
> it from terminal with the style you want passed as a parameter.
> 
> e.g.
> 
> texmaker -style gtk

I cannot see anydifference. I tried gtk, qtcurve, orion and windows, but it looks all the same.
Comment 8 jorgicio 2015-06-23 19:12:32 UTC
(In reply to Justin Lecher from comment #7)
> (In reply to jorgicio from comment #6)
> > (In reply to Justin Lecher from comment #5)
> > > (In reply to jorgicio from comment #4)
> > > > Yes, I reported that issue, just in case only.
> > > 
> > > yes, I know. I just added the reference here.
> > > 
> > > How can I test the functionality of the patch?
> > 
> > After patch applied and compiled manually with the ebuild (and installed the
> > respective package), just set the style as an environment variable, or run
> > it from terminal with the style you want passed as a parameter.
> > 
> > e.g.
> > 
> > texmaker -style gtk
> 
> I cannot see anydifference. I tried gtk, qtcurve, orion and windows, but it
> looks all the same.

It depends on which DE are you using. Of course not if you use a QT5-based DE.
Comment 9 jorgicio 2015-06-23 19:16:03 UTC
(In reply to Justin Lecher from comment #7)
> (In reply to jorgicio from comment #6)
> > (In reply to Justin Lecher from comment #5)
> > > (In reply to jorgicio from comment #4)
> > > > Yes, I reported that issue, just in case only.
> > > 
> > > yes, I know. I just added the reference here.
> > > 
> > > How can I test the functionality of the patch?
> > 
> > After patch applied and compiled manually with the ebuild (and installed the
> > respective package), just set the style as an environment variable, or run
> > it from terminal with the style you want passed as a parameter.
> > 
> > e.g.
> > 
> > texmaker -style gtk
> 
> I cannot see anydifference. I tried gtk, qtcurve, orion and windows, but it
> looks all the same.

Also, since QT5, there are only 3 styles: gtk, fusion and windows.
There are my screenshots:

GTK+:
http://gyazo.com/43c7bd12b4a8d023a2e2e8995ee8c468

Fusion:
http://gyazo.com/37448a7464f026c6f5fe2dc9da696cce

Windows:
http://gyazo.com/e0f67a7fa47a26b390f14333c641d33f
Comment 10 Justin Lecher (RETIRED) gentoo-dev 2015-06-24 06:29:34 UTC
Although we normally try to not diverge from upstream I hope this one is for the good.

+*texmaker-4.4.1-r1 (24 Jun 2015)
+
+  24 Jun 2015; Justin Lecher <jlec@gentoo.org>
+  +files/texmaker-4.4.1-modern-styles.patch, +texmaker-4.4.1-r1.ebuild:
+  Add support for multiple styles in Qt5, thanks jorgicio for the patch;
+  http://code.google.com/p/texmaker/issues/detail?id=1511
+