Bug 552460 – net-misc/dahdi-2.10.1: : /var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7056:2: error: void value not ignored as it ought to be

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Toralf Förster 2015-06-18 13:01:02 UTC]

Created attachment 405322 [details]
emerge log

*   02-parallel-make.diff ...
 [ ok ]
 *   03-grsecurity-no-constify.diff ...
 [ ok ]
 *   98-non-digium-hardware-and-oslec.diff ...
 [ ok ]
 * Done with patching
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1 ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1 ...
make -j1 V=1 CC=x86_64-pc-linux-gnu-gcc LD=x86_64-pc-linux-gnu-ld KSRC=/lib/modules/4.0.5-gentoo/build DESTDIR=/var/tmp/portage/net-misc/dahdi-2.10.1/image/ 'DAHDI_MODULES_EXTRA=cwain.o qozap.o ztgsm.o' all 
make -C drivers/dahdi/firmware firmware-loaders
make[1]: Entering directory '/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/firmware'
make[1]: Leaving directory '/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/firmware'
make -C /lib/modules/4.0.5-gentoo/build SUBDIRS=/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi DAHDI_INCLUDE=/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/include DAHDI_MODULES_EXTRA="cwain.o qozap.o ztgsm.o" HOTPLUG_FIRMWARE=yes modules DAHDI_BUILD_ALL=m
make[1]: Entering directory '/usr/src/linux-4.0.5-gentoo'
test -e include/generated/autoconf.h -a -e include/config/auto.conf || (		\
echo >&2;							\
echo >&2 "  ERROR: Kernel configuration is invalid.";		\
echo >&2 "         include/generated/autoconf.h or include/config/auto.conf are missing.";\
echo >&2 "         Run 'make oldconfig && make prepare' on kernel src to fix it.";	\
echo >&2 ;							\
/bin/false)
mkdir -p /var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/.tmp_versions ; rm -f /var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/.tmp_versions/*
make -f ./scripts/Makefile.build obj=/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi
  x86_64-pc-linux-gnu-gcc -Wp,-MD,/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/.dahdi-base.o.d  -nostdinc -isystem /usr/lib/gcc/x86_64-pc-linux-gnu/4.8.4/include -I./arch/x86/include -Iarch/x86/include/generated/uapi -Iarch/x86/include/generated  -Iinclude -I./arch/x86/include/uapi -Iarch/x86/include/generated/uapi -I./include/uapi -Iinclude/generated/uapi -include ./include/linux/kconfig.h -D__KERNEL__ -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -std=gnu89 -m64 -mno-80387 -mno-fp-ret-in-387 -mtune=generic -mno-red-zone -mcmodel=kernel -funit-at-a-time -maccumulate-outgoing-args -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -DCONFIG_AS_CFI_SECTIONS=1 -DCONFIG_AS_FXSAVEQ=1 -DCONFIG_AS_SSSE3=1 -DCONFIG_AS_CRC32=1 -DCONFIG_AS_AVX=1 -DCONFIG_AS_AVX2=1 -pipe -Wno-sign-compare -fno-asynchronous-unwind-tables -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -fno-delete-null-pointer-checks -O2 --param=allow-store-data-races=0 -Wframe-larger-than=2048 -fno-stack-protector -Wno-unused-but-set-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-var-tracking-assignments -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -Werror=implicit-int -Werror=strict-prototypes -DCC_HAVE_ASM_GOTO -DHAVE_HRTIMER_ACCESSORS=1  -DMODULE  -I/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/include -I/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi -DHAVE_WAIT_FOR_COMPLETION_TIMEOUT=1 -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(dahdi_base)"  -D"KBUILD_MODNAME=KBUILD_STR(dahdi)" -c -o /var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.o /var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c: In function ‘set_spanno_and_basechan’:
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7056:2: error: void value not ignored as it ought to be
  dahdi_dev_dbg(ASSIGN, span_device(span),
  ^
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c: In function ‘_assign_spanno_and_basechan’:
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7080:2: error: void value not ignored as it ought to be
  dahdi_dev_dbg(ASSIGN, span_device(span),
  ^
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7100:2: error: void value not ignored as it ought to be
  dahdi_dev_dbg(ASSIGN, span_device(span),
  ^
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c: In function ‘_check_spanno_and_basechan’:
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7150:2: error: void value not ignored as it ought to be
  dahdi_dev_dbg(ASSIGN, span_device(span),
  ^
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7156:3: error: void value not ignored as it ought to be
   dahdi_dev_dbg(ASSIGN, span_device(span),
   ^
/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.c:7184:2: error: void value not ignored as it ought to be
  dahdi_dev_dbg(ASSIGN, span_device(span),
  ^
scripts/Makefile.build:258: recipe for target '/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.o' failed
make[2]: *** [/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi/dahdi-base.o] Error 1
Makefile:1390: recipe for target '_module_/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi' failed
make[1]: *** [_module_/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1/drivers/dahdi] Error 2
make[1]: Leaving directory '/usr/src/linux-4.0.5-gentoo'
Makefile:74: recipe for target 'modules' failed
make: *** [modules] Error 2
 * ERROR: net-misc/dahdi-2.10.1::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=net-misc/dahdi-2.10.1::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=net-misc/dahdi-2.10.1::gentoo'`.
 * The complete build log is located at '/var/log/portage/net-misc:dahdi-2.10.1:20150618-032149.log'.
 * For convenience, a symlink to the build log is located at '/var/tmp/portage/net-misc/dahdi-2.10.1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/net-misc/dahdi-2.10.1/temp/environment'.
 * Working directory: '/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1'
 * S: '/var/tmp/portage/net-misc/dahdi-2.10.1/work/dahdi-linux-2.10.1'

  -----------------------------------------------------------------

  This is an stable amd64 chroot image (named amd64-stable_20150615-204131) at a hardened host acting as a tinderbox.

Portage 2.2.18 (python 2.7.9-final-0, default/linux/amd64/13.0/desktop/kde, gcc-4.8.4, glibc-2.20-r2, 4.0.5-hardened x86_64)
=================================================================
System uname: Linux-4.0.5-hardened-x86_64-Intel-R-_Core-TM-_i7-3770_CPU_@_3.40GHz-with-gentoo-2.2
KiB Mem:    16164692 total,   1572584 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Wed, 17 Jun 2015 21:45:01 +0000
sh bash 4.3_p33-r2
ld GNU ld (Gentoo 2.24 p1.4) 2.24
app-shells/bash:          4.3_p33-r2::gentoo
dev-java/java-config:     2.2.0::gentoo
dev-lang/perl:            5.20.2::gentoo
dev-lang/python:          2.7.9-r1::gentoo, 3.3.5-r1::gentoo
dev-util/cmake:           3.2.2::gentoo
dev-util/pkgconfig:       0.28-r2::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.16.4::gentoo
sys-apps/sandbox:         2.6-r1::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69::gentoo
sys-devel/automake:       1.9.6-r4::gentoo, 1.10.3-r1::gentoo, 1.11.6-r1::gentoo, 1.13.4::gentoo, 1.14.1::gentoo
sys-devel/binutils:       2.24-r3::gentoo
sys-devel/gcc:            4.8.4::gentoo
sys-devel/gcc-config:     1.7.3::gentoo
sys-devel/libtool:        2.4.6::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 3.18::gentoo (virtual/os-headers)
sys-libs/glibc:           2.20-r2::gentoo
Repositories:

local
    location: /usr/local/portage
    masters: gentoo

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: 9999

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.5/ext-active/ /etc/php/apache2-php5.6/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/var/tmp/distfiles"
EMERGE_DEFAULT_OPTS="--nospinner --tree --quiet-build"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo rsync://mirror.netcologne.de/gentoo/ ftp://sunsite.informatik.rwth-aachen.de/pub/Linux/gor.bytemark.co.uk/gentoo/ rsync://ftp.snt.utwente.nl/gentoo"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi aes-ni alsa amd64 apache2 avx avx2 berkdb bluetooth branding btrfs bzip2 cairo cdda cdr cli consolekit corefonts cracklib crypt cups cxx dbus declarative designer dnssec dot dri drmkms dts dvd dvdr ecc emboss encode exif extraengine fam ffmpeg firefox flac fontconfig fortran fpm gd gdbm gif glamor gpm gtk gudev gui iconv icu ipv6 isag jadetex jpeg kde kipi kvm lapack lcms libkms libnotify libvirtd logrotate mad mbox minizip mmx mmxext mng modules mp3 mp4 mpeg multilib mysql ncurses nls nptl ogg opengl openmp openssl pam pango pax_kernel pcre pcre16 pdf phonon plasma png policykit ppds pwquality python qemu qt3support qt4 readline scrpyt sdl session spell spice sqlite sse sse2 sse4 sse4_1 sse4_2 ssh-askpass ssl ssse3 startup-notification svg tcpd theora thinkpad threads tiff tk tls truetype udev udisks uml unicode upower usb usbredir uxa v4l v4l2 video vorbis wxwidgets x264 xa xcb xcomposite xinerama xkb xml xmp xscreensaver xslt xv xvfb xvid xvmc zenmap zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea n trip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en en_GB" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

[Comment 1 Toralf Förster 2015-06-18 13:01:16 UTC]

Created attachment 405324 [details]
package history

[Comment 2 Oliver Jaksch 2015-06-25 14:24:08 UTC]

Just received the same error on an arch-linux vm. Found out that dahdi-2.10.2 is out since 2015-06-15; patches still apply and error on base.c seems to be gone but now compiling stops at wcopenpci.c with

/stuff/dahdi-2.10.2/src/dahdi-linux-complete-2.10.2+2.10.2/linux/drivers/dahdi/wcopenpci.c: In function ‘openpci_probe_board’:
/stuff/dahdi-2.10.2/src/dahdi-linux-complete-2.10.2+2.10.2/linux/drivers/dahdi/wcopenpci.c:1675:42: error: ‘DAHDI_IRQ_SHARED’ undeclared (first use in this function)
  if (request_irq(pdev->irq, openpci_isr, DAHDI_IRQ_SHARED, NAME, wc)) {
                                          ^
/stuff/dahdi-2.10.2/src/dahdi-linux-complete-2.10.2+2.10.2/linux/drivers/dahdi/wcopenpci.c:1675:42: note: each undeclared identifier is reported only once for each function it appears in
scripts/Makefile.build:264: recipe for target '/stuff/dahdi-2.10.2/src/dahdi-linux-complete-2.10.2+2.10.2/linux/drivers/dahdi/wcopenpci.o' failed
make[2]: *** [/stuff/dahdi-2.10.2/src/dahdi-linux-complete-2.10.2+2.10.2/linux/drivers/dahdi/wcopenpci.o] Error 1
Makefile:1390: recipe for target '_module_/stuff/dahdi-2.10.2/src/dahdi-linux-complete-2.10.2+2.10.2/linux/drivers/dahdi' failed
make[1]: *** [_module_/stuff/dahdi-2.10.2/src/dahdi-linux-complete-2.10.2+2.10.2/linux/drivers/dahdi] Error 2

This need some further investigation - at my gentoo box (stable since 10 years)

[Comment 3 Jaco Kroon 2015-06-26 15:36:21 UTC]

Hi,

After looking at te code I'm somewhat convinced it's a compiler error.  The protoype for dev_printk has changed recently, from

int dev_printk(const char *level, const struct device *dev,
           const char *fmt, ...);

to:

void dev_printk(const char *level, const struct device *dev,
                 const char *fmt, ...);

This is depended on by the macro dahdi_dev_dbg:

#define dahdi_dev_dbg(bits, dev, fmt, ...)         \
        do { if (debug & (DAHDI_DBG_ ## bits)) { \
            dev_printk(KERN_DEBUG, dev, \
            "DBG-%s(%s): " fmt, #bits, __func__, ## __VA_ARGS__); \
        } } while (0)


As can be plainly seen the return value from dev_printk is being ignored.  I do however recall something about gcc generating return values on the fly for certain types of macros, can't recall the syntax but I don't think it applies here.

Based on this I'm more inclined to think "compiler bug" rather than "dahdi bug", so if you don't mind trying with a 4.9.X compiler instead please?  I'll be honest in saying I don't know if this will change anything.

Oliver - a bump is actually a good idea too.  04-strnicmp-void.diff does however NOT apply for me - did you rename from 2.10.1 or 2.10.1-r1?

That patch seems to be the only difference from 2.10.1 to 2.10.1-r1 - Tony to confirm.

From the 2.10.1 sources it seems the defines for the missing identifiers was as follows:

./include/dahdi/kernel.h:#define DAHDI_IRQ_SHARED IRQF_SHARED
./include/dahdi/kernel.h:#define DAHDI_IRQ_SHARED_DISABLED IRQF_SHARED | IRQF_DISABLED

So basically we need to figure out why those defines are no longer available, and more specifically WHY they changed so that we can update 98non-digium as well.  For that matter, we should probably investigate if a newer version of that patch is perhaps available but I honestly have no idea where to start looking.

[Comment 4 Oliver Jaksch 2015-06-26 17:28:06 UTC]

(In reply to Jaco Kroon from comment #3)

> Based on this I'm more inclined to think "compiler bug" rather than "dahdi
> bug", so if you don't mind trying with a 4.9.X compiler instead please? 
> I'll be honest in saying I don't know if this will change anything.

At my site this "bug" happened with gcc 4.8.4 (gentoo) and 5.1.0 (arch) - but this was a quick'n'dirty shot at both machines, so I've to reproduce this in silende.

 
> Oliver - a bump is actually a good idea too.  04-strnicmp-void.diff does
> however NOT apply for me - did you rename from 2.10.1 or 2.10.1-r1?
> That patch seems to be the only difference from 2.10.1 to 2.10.1-r1 - Tony
> to confirm.

Bump is in progress; I just renamed 2.10.1-r1 to 2.10.2 but leaving out 04-strnicmp-void.diff as it is already included in 2.10.2

[Comment 5 Oliver Jaksch 2015-06-27 05:13:44 UTC]

Bumps for 2.10.2 of dahdi and dahdi-tools created.
imho bug #553238 should be marked as duplicate of #552460

[Comment 6 Jaco Kroon 2015-06-29 08:23:59 UTC]

Hi Oliver,

Thanks for the efforts.

Have you managed to figure out what needs to happen with these?

./include/dahdi/kernel.h:#define DAHDI_IRQ_SHARED IRQF_SHARED
./include/dahdi/kernel.h:#define DAHDI_IRQ_SHARED_DISABLED IRQF_SHARED | IRQF_DISABLED

Also, if 4.8.4 and 5.X is both giving the same error I'm inclined to think it may actually be a real problem with the DAHDI code.  A version bump is probably the simplest fix.

[Comment 7 Oliver Jaksch 2015-06-29 09:10:30 UTC]

(In reply to Jaco Kroon from comment #6)
> Hi Oliver,
> 
> Thanks for the efforts.

...glad I could help :)

 
> Have you managed to figure out what needs to happen with these?
> 
> ./include/dahdi/kernel.h:#define DAHDI_IRQ_SHARED IRQF_SHARED
> ./include/dahdi/kernel.h:#define DAHDI_IRQ_SHARED_DISABLED IRQF_SHARED |
> IRQF_DISABLED

No, not until now. They changed only a few lines in kernel.h but primary they omit the DAHDI_IRQ_xxx definitions for unknown reasons :(

----------------------------------------------------------------
--- kernel.h-2.10.1     2015-06-29 10:50:14.359952260 +0200
+++ kernel.h-2.10.2     2015-06-15 21:37:29.000000000 +0200
@@ -76,10 +76,6 @@
 #define HAVE_NET_DEVICE_OPS
 #endif
 
-#define DAHDI_IRQ_SHARED IRQF_SHARED
-#define DAHDI_IRQ_DISABLED IRQF_DISABLED
-#define DAHDI_IRQ_SHARED_DISABLED IRQF_SHARED | IRQF_DISABLED
-
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 26)
 #  ifdef RHEL_RELEASE_VERSION
 #    if RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(5, 6)
@@ -1502,6 +1498,8 @@
 #define list_first_entry(ptr, type, member) \
        list_entry((ptr)->next, type, member)
 
+#define strncasecmp strnicmp
+
 #ifndef __packed
 #define __packed  __attribute__((packed))
 #endif 
@@ -1665,9 +1663,11 @@
                                chan_printk(DEBUG, "-" #bits, chan, \
                                        "%s: " fmt, __func__, ## __VA_ARGS__)))
 #define dahdi_dev_dbg(bits, dev, fmt, ...)         \
-                       ((void)((debug & (DAHDI_DBG_ ## bits)) && \
+               do { if (debug & (DAHDI_DBG_ ## bits)) { \
                        dev_printk(KERN_DEBUG, dev, \
-                       "DBG-%s(%s): " fmt, #bits, __func__, ## __VA_ARGS__)))
+                       "DBG-%s(%s): " fmt, #bits, __func__, ## __VA_ARGS__); \
+               } } while (0)
+
 #endif /* DAHDI_PRINK_MACROS_USE_debug */
 
 #endif /* _DAHDI_KERNEL_H */
----------------------------------------------------------------


> Also, if 4.8.4 and 5.X is both giving the same error I'm inclined to think
> it may actually be a real problem with the DAHDI code.  A version bump is
> probably the simplest fix.

I'm still stuck serving customer support for fuckin' WIN and had no time to check this in detail. Hope I get more spare time this monday.

[Comment 8 Oliver Jaksch 2015-06-29 10:03:42 UTC]

Damn! Forgot to mention that I'm on diff'ing and testing with dahdi-2.10.2
 
> > Have you managed to figure out what needs to happen with these?
> > 
> > ./include/dahdi/kernel.h:#define DAHDI_IRQ_SHARED IRQF_SHARED
> > ./include/dahdi/kernel.h:#define DAHDI_IRQ_SHARED_DISABLED IRQF_SHARED |
> > IRQF_DISABLED
> 
> No, not until now. They changed only a few lines in kernel.h but primary
> they omit the DAHDI_IRQ_xxx definitions for unknown reasons :(


But the good news are that 2.10.2 IS compiling cleanly with gcc 4.8.4 (gentoo) AND 5.1.0 (arch) WHEN re-including DAHDI_IRQ_xxx definitions to include/dahdi/kernel.h that at least wcopenpci is depending on.

As usual: no further tests done. Will try to get 2.10.2 working on my production system to make some calls and post report here and with fix on kernel.h at bug 553388

[Comment 9 Tony Vroon (RETIRED) 2015-06-29 13:44:52 UTC]

This will have been addressed upstream in DAHDI 2.10.2 which is now in the tree thanks to Oliver Jaksch. Thank you for your report.