Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 552392 - =dev-util/shellcheck-0.3.7: version bump
Summary: =dev-util/shellcheck-0.3.7: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Justin Lecher (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2015-06-17 16:28 UTC by Coacher
Modified: 2015-06-19 15:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
shellcheck-0.3.7.ebuild (shellcheck-0.3.7.ebuild,953 bytes, text/plain)
2015-06-17 16:31 UTC, Coacher
Details
shellcheck-0.3.7.ebuild (shellcheck-0.3.7.ebuild,989 bytes, text/plain)
2015-06-19 14:08 UTC, Coacher
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Coacher 2015-06-17 16:28:38 UTC
Hello.

shellcheck-0.3.7 was released recently, see [0]. Among other changes it is now uses dev-haskell/regex-tdfa instead of dev-haskell/regex-compat.

Please bump

[0]: https://github.com/koalaman/shellcheck/releases/tag/v0.3.7

Reproducible: Always
Comment 1 Coacher 2015-06-17 16:31:20 UTC
Created attachment 405288 [details]
shellcheck-0.3.7.ebuild

A proposed ebuild for 0.3.7. This is simply the 0.3.6 ebuild with updated dependency. Compiles and works fine on my amd64 machine.

Diff:
--- a/dev-util/shellcheck/shellcheck-0.3.6.ebuild
+++ b/dev-util/shellcheck/shellcheck-0.3.7.ebuild
@@ -1,6 +1,6 @@
 # Copyright 1999-2015 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/dev-util/shellcheck/shellcheck-0.3.6.ebuild,v 1.2 2015/06/17 09:28:53 jlec Exp $
+# $Header: $

 EAPI=5

@@ -13,9 +13,7 @@ MY_P="${MY_PN}-${PV}"

 DESCRIPTION="Shell script analysis tool"
 HOMEPAGE="http://www.shellcheck.net/"
-SRC_URI="
-       mirror://hackage/packages/archive/${MY_PN}/${PV}/${MY_P}.tar.gz"
-#      http://dev.gentoo.org/~mjo/distfiles/${PN}-man-${PV}.tar.xz"
+SRC_URI="mirror://hackage/packages/archive/${MY_PN}/${PV}/${MY_P}.tar.gz"

 LICENSE="AGPL-3"
 SLOT="0/${PV}"
@@ -27,7 +25,7 @@ RDEPEND="
        dev-haskell/mtl:=[profile?]
        dev-haskell/parsec:=[profile?]
        >=dev-haskell/quickcheck-2.7.4:2=[profile?]
-       dev-haskell/regex-compat:=[profile?]
+       dev-haskell/regex-tdfa:=[profile?]
        dev-haskell/transformers:=[profile?]
        >=dev-lang/ghc-7.8.4:=
 "
Comment 2 Andrew Miller 2015-06-18 14:08:42 UTC
It needs >=dev-haskell/cabal-1.20.

With =dev-haskell/cabal-1.18.1.2 it fails in the test phase:

>Setup.hs: You need to re-run the 'configure' command. The version of Cabal
being used has changed (was Cabal-1.18.1.2, now Cabal-1.18.1.5).
>* ERROR: dev-util/shellcheck-0.3.7::testing failed (test phase):

And in the install phase:

>setup: You need to re-run the 'configure' command. The version of Cabal being
used has changed (was Cabal-1.18.1.5, now Cabal-1.18.1.2).
>* ERROR: dev-util/shellcheck-0.3.7::testing failed (install phase):
Comment 3 Coacher 2015-06-18 20:44:42 UTC
(In reply to Andrew Miller from comment #2)
> It needs >=dev-haskell/cabal-1.20.
> 
> With =dev-haskell/cabal-1.18.1.2 it fails in the test phase:
> ...
> 
> And in the install phase:
> ...

I have it installed and working without any errors with cabal-1.18.1.2.
Tests indeed fail with cabal-1.18.1.2 and succeed with cabal-1.20.0.2.

Can you confirm this?
Comment 4 Andrew Miller 2015-06-19 08:03:41 UTC
OK, some more information. I encountered the error in the install phase when I tried to workaround the error in the test phase.

If I disable tests with FEATURES="-test", it builds with cabal-1.18.1.2.
Comment 5 Andrew Miller 2015-06-19 09:47:38 UTC
(In reply to Coacher from comment #3)
> I have it installed and working without any errors with cabal-1.18.1.2.
> Tests indeed fail with cabal-1.18.1.2 and succeed with cabal-1.20.0.2.
> 
> Can you confirm this?

Confirmed.

1. With cabal-1.18.1.2 and FEATURES="test", this builds:

>src_test() {
>        haskell-cabal_src_test
>}

2. With cabal-1.18.1.2 and FEATURES="test", this fails in the test phase:

>src_test() {
>        runghc Setup.hs test || die 'test suite failed'
>}

3. With cabal-1.18.1.2 and FEATURES="test", this fails in the install phase:

>src_test() {
>        runghc Setup.hs configure --enable-tests || die
>        runghc Setup.hs test || die 'test suite failed'
>}

4. With cabal-1.20.0.2 and FEATURES="test", this builds:

>src_test() {
>        runghc Setup.hs test || die 'test suite failed'
>}

5. With FEATURES="-test", it builds regardless of what you have in src_test().
Comment 6 Coacher 2015-06-19 14:08:01 UTC
Created attachment 405376 [details]
shellcheck-0.3.7.ebuild

(In reply to Andrew Miller from comment #5)

Thank you very much for the detailed info, Andrew.

Since shellcheck-0.3.7 requires a somewhat recent cabal only for tests, we should also add this dependency only if tests are enabled. I've updated the proposed ebuild accordingly.
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2015-06-19 15:31:41 UTC
+*shellcheck-0.3.7 (19 Jun 2015)
+
+  19 Jun 2015; Justin Lecher <jlec@gentoo.org> +shellcheck-0.3.7.ebuild:
+  Version Bump bug #552392; thanks Coacher for the ebuild
+