Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 551432 - app-eselect/eselect-ruby should check RUBY_TARGETS
Summary: app-eselect/eselect-ruby should check RUBY_TARGETS
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
: 484278 485158 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-06-07 09:50 UTC by Hans de Graaff
Modified: 2021-01-23 14:40 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hans de Graaff gentoo-dev Security 2015-06-07 09:50:12 UTC
eselecting a ruby version that is not also listed in RUBY_TARGETS is not a good idea in general. eselect-ruby should check this. Several options come to mind:

1) only show ruby versions listed in RUBY_TARGETS and perhaps add a second set command to override this

2) give a warning when such a ruby version is eselected and show status with the list command
Comment 1 Manuel Rüger (RETIRED) gentoo-dev 2015-06-07 12:18:41 UTC
I'm in favor of option 2).
Maybe we can add some pkg_postinst message, via our ruby eclasses, that notifies the user about this issue.
Comment 2 Juergen Rose 2015-06-11 08:56:09 UTC
Where is RUBY_TARGETS set, if there is not a setting in /etc/make.conf?
Comment 3 Hans de Graaff gentoo-dev Security 2015-06-14 08:41:54 UTC
(In reply to Manuel Rüger from comment #1)
> I'm in favor of option 2).
> Maybe we can add some pkg_postinst message, via our ruby eclasses, that
> notifies the user about this issue.

profiles/base/make.defaults
Comment 4 Manuel Rüger (RETIRED) gentoo-dev 2015-06-14 12:40:35 UTC
I thought about something like that:

all_ruby_fakegem_pkg-postinst() {
    if [[ ${RUBY_TARGETS} =~ .*${RUBY}.* ]]; then
       ewarn "Your currently eselected ruby is not included in your current RUBY_TARGETS" 
    fi  

}
Comment 5 Hans de Graaff gentoo-dev Security 2015-07-07 09:08:18 UTC
*** Bug 485158 has been marked as a duplicate of this bug. ***
Comment 6 Hans de Graaff gentoo-dev Security 2015-07-07 09:09:24 UTC
*** Bug 484278 has been marked as a duplicate of this bug. ***