551202 – x11-misc/tinymount: 'nonfatal sed' is incorrect

Bug 551202 - x11-misc/tinymount: 'nonfatal sed' is incorrect

Summary: x11-misc/tinymount: 'nonfatal sed' is incorrect

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Mike Limansky

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-06-04 09:54 UTC by Michał Górny
Modified:	2015-06-04 18:06 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2015-06-04 09:54:28 UTC

remove_locale() {
           # this is nonfatal sed, so '|| die' unneeded here
           sed -i -e "/TRANSLATIONS/s/translations\/${PN}_${1}.ts//" src/src.pro
   }

sed can only fail if src/src.pro doesn't exist. Also, you shouldn't call this on locales that don't exist.

Comment 1 Davide Pesavento (RETIRED) gentoo-dev

2015-06-04 18:06:14 UTC

Thanks, fixed, but I don't know what you mean by "you shouldn't call this on locales that don't exist".