Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 551176 - games-roguelike/nethack: incorrectly ignores cp return status
Summary: games-roguelike/nethack: incorrectly ignores cp return status
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mira Ressel
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-04 09:22 UTC by Michał Górny
Modified: 2015-06-09 08:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-06-04 09:22:33 UTC 
# preserve STATEDIR/{logfile,record} (previous ebuild rev mistakenly removes it)
    cp "${ROOT}/${STATEDIR}/"{logfile,record} "$T"  # nonfatal

This is just wrong. Check whether the file exists, then call cp, then die if cp fails.
Comment 1 Sven Vermeulen (RETIRED) gentoo-dev 2015-06-09 08:36:22 UTC 
Luis sent out the updated ebuild and it's committed to the tree (as -r4).