Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 550640 - devmanual.gentoo.org: html doesn't validate
Summary: devmanual.gentoo.org: html doesn't validate
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Devmanual Team
URL: https://validator.w3.org/check?uri=ht...
Whiteboard:
Keywords: InVCS, PATCH
Depends on:
Blocks:
 
Reported: 2015-05-28 13:08 UTC by Ulrich Müller
Modified: 2015-06-01 20:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-use-HTML5-doctype-instead-of-xhtml-one.patch (0001-use-HTML5-doctype-instead-of-xhtml-one.patch,1.61 KB, patch)
2015-05-31 09:35 UTC, Markus Meier
Details | Diff
0002-use-html-output-to-avoid-invalid-self-closing-elemen.patch (0002-use-html-output-to-avoid-invalid-self-closing-elemen.patch,713 bytes, patch)
2015-05-31 09:43 UTC, Markus Meier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2015-05-28 13:08:47 UTC
See URL. The pages declare themselves as doctype XHTML 1.0 Strict which seems to be incompatible with some elements of the Tyrian layout (which requires HTML 5).

Subpages suffer from the same issue.
Comment 1 Markus Meier gentoo-dev 2015-05-31 09:35:16 UTC
Created attachment 404364 [details, diff]
0001-use-HTML5-doctype-instead-of-xhtml-one.patch

This patch switches to html5 doctype, which should partially fix this issue. The head of the file will look like that:

<!DOCTYPE html><html>
  <head>
    <title>Gentoo Development Guide: Master Index</title>
...


But then it complains about the self closing <span> element in "Get Gentoo!".
Comment 2 Markus Meier gentoo-dev 2015-05-31 09:43:09 UTC
Created attachment 404366 [details, diff]
0002-use-html-output-to-avoid-invalid-self-closing-elemen.patch

This patch will use the html output instead of the xml one that will avoid the invalid self closing elements. Downside is that the output isn't indented anymore - but that's a minor issue I think.
Like that there's just one validation error left, but that's not devmanual specific, the same occurs when validating infra-status.
Comment 3 Alex Legler (RETIRED) archtester gentoo-dev Security 2015-05-31 09:53:46 UTC
Heh, thanks for fixing this before I even had a chance to look at it.

Assigning to devmanual folks.
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2015-05-31 13:00:24 UTC
Thanks! So I guess we will wait for infra@ to deploy the new code and we will close this once it passes the html validation.
Comment 6 Ulrich Müller gentoo-dev 2015-06-01 05:11:55 UTC
(In reply to Markos Chandras from comment #5)
> Thanks! So I guess we will wait for infra@ to deploy the new code and we
> will close this once it passes the html validation.

CCing infra.
Comment 7 Ulrich Müller gentoo-dev 2015-06-01 16:16:31 UTC
We are down to one error now:
Error Line 16, Column 70: Bad value button for attribute type on element a: Subtype missing.

It's caused by this line in devbook.xsl:
<a href="http://get.gentoo.org/" type="button" class="btn get-gentoo"><span class="fa fa-download"></span> <strong>Get Gentoo!</strong></a>
Comment 8 Alex Legler (RETIRED) archtester gentoo-dev Security 2015-06-01 17:56:31 UTC
(In reply to Ulrich Müller from comment #7)
> We are down to one error now:
> Error Line 16, Column 70: Bad value button for attribute type on element a:
> Subtype missing.
> 
> It's caused by this line in devbook.xsl:
> <a href="http://get.gentoo.org/" type="button" class="btn get-gentoo"><span
> class="fa fa-download"></span> <strong>Get Gentoo!</strong></a>

Should be role="button"
Comment 9 Ulrich Müller gentoo-dev 2015-06-01 20:46:25 UTC
(In reply to Alex Legler from comment #8)
> > It's caused by this line in devbook.xsl:
> > <a href="http://get.gentoo.org/" type="button" class="btn get-gentoo"><span
> > class="fa fa-download"></span> <strong>Get Gentoo!</strong></a>
> 
> Should be role="button"

I've pushed a fix:
https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=3770c96d9ec2e2277dbf0108f9b00e64cc217e24

Validation passes without errors now, therefore closing.