Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 550506 - app-emulation/wine-9999: Failed Patch: 0001-atl-Added-stub-AtlIPersistPropertyBag_Save.patch
Summary: app-emulation/wine-9999: Failed Patch: 0001-atl-Added-stub-AtlIPersistPropert...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-27 00:08 UTC by Leonardo Amaral
Modified: 2015-05-29 20:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-atl-Added-stub-AtlIPersistPropertyBag_Save.patch.out (0001-atl-Added-stub-AtlIPersistPropertyBag_Save.patch.out,13.66 KB, text/plain)
2015-05-27 00:08 UTC, Leonardo Amaral
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Leonardo Amaral 2015-05-27 00:08:24 UTC
From 20150526 build attempt:

 * Failed Patch: 0001-atl-Added-stub-AtlIPersistPropertyBag_Save.patch !
 *  ( /var/tmp/portage/app-emulation/wine-9999/work/wine-staging-9999/patches/atl-AtlIPersistPropertyBag_Save/0001-atl-Added-stub-AtlIPersistPropertyBag_Save.patch )

USE flags:

[ebuild   R   *] app-emulation/wine-9999::gentoo  USE="X alsa cups dos fontconfig gecko gsm jpeg lcms ldap mono mp3 ncurses nls odbc openal opencl opengl osmesa perl png prelink pulseaudio realtime run-exes samba scanner ssl staging threads truetype udisks v4l vaapi xcomposite xinerama xml -capi -custom-cflags -gphoto2 -gstreamer -netapi -oss -pcap -pipelight -s3tc (-selinux) {-test}" ABI_X86="32 64 (-x32)" LINGUAS="en pt_BR -ar -bg -ca -cs -da -de -el -en_US -eo -es -fa -fi -fr -he -hi -hr -hu -it -ja -ko -lt -ml -nb_NO -nl -or -pa -pl -pt_PT -rm -ro -ru -sk -sl -sr_RS@cyrillic -sr_RS@latin -sv -te -th -tr -uk -wa -zh_CN -zh_TW"

Reproducible: Always

Steps to Reproduce:
1. emerge -av app-emulation/wine-9999
Comment 1 Leonardo Amaral 2015-05-27 00:08:50 UTC
Created attachment 404042 [details]
0001-atl-Added-stub-AtlIPersistPropertyBag_Save.patch.out
Comment 2 jospezial 2015-05-27 23:45:14 UTC
The patch is not needed any longer.

It was committed upstream.

https://github.com/wine-mirror/wine/commit/852f6a5bccc0ce37dd06509dd866e2f4d6023b0d
Comment 3 Sebastian Lackner 2015-05-29 16:53:40 UTC
Hi,

I am one of the Wine-Staging maintainers. You are trying to use -9999 with the staging USE-flag, which means a huge amount of extra patches will be pulled in.

Since multiple repositories are involved, the wine upstream repository and the Wine-Staging repository with the patches, its kinda expected that -9999 will break from time to time. This is nothing the Gentoo people can fix on their own, you have to wait till after the next commit round in Wine-Staging. We are currently preparing the next Wine-Staging release, and as part of that I've already removed the patch locally.

If you encounter such problems in the future, a more suitable place to report such issues would be our bugs.wine-staging.com bugtracker, or alternatively to ping us on IRC (#wine-staging on Freenode). Nevertheless, it is usually not necessary, we have automated scripts to detect patch apply failures, so we are totally aware when our patches do not apply.

@NP-Hardass: The only thing which could be fixed here is probably to put a warning somewhere. Please note that we recently also added the "patchinstall.sh --version" command, which outputs the last commit sha for which our patches are guaranteed to apply to. Not sure if its possible, but maybe you could even use this information to check out a specific commit of wine, instead of just HEAD.

Regards,
Sebastian
Comment 4 Adam Feldman gentoo-dev 2015-05-29 20:07:35 UTC
(In reply to Sebastian Lackner from comment #3)
> Since multiple repositories are involved, the wine upstream repository and
> the Wine-Staging repository with the patches, its kinda expected that -9999
> will break from time to time. This is nothing the Gentoo people can fix on
> their own, you have to wait till after the next commit round in
> Wine-Staging. We are currently preparing the next Wine-Staging release, and
> as part of that I've already removed the patch locally.

Sebastian,

You guys usually refactor those out pretty quickly.  I'm assuming that you opted not to, this time, due to the proximity to the next release?
Comment 5 Adam Feldman gentoo-dev 2015-05-29 20:36:35 UTC
Since we just have to wait for their release (within the next day or so), I'm just going close it as WONTFIX, as my inaction will resolve it in a day.