Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 550022 - dispatch-conf chokes on non-ASCII filenames (portage-2.2.18/19)
Summary: dispatch-conf chokes on non-ASCII filenames (portage-2.2.18/19)
Status: RESOLVED OBSOLETE
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-21 08:35 UTC by Hector Martin
Modified: 2020-06-21 05:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hector Martin 2015-05-21 08:35:52 UTC
To-be-updated config files with non-ASCII characters in their name cause dispatch-conf to crash.

As it turns out, for some reason a reinstall of app-misc/ca-certificates triggered a bunch of config file updates under /etc/ssl/certs. Some of those CAs have names with non-ASCII characters, such as this one:

lrwxrwxrwx 1 root root 73 May 21 10:16 AC_Raíz_Certicámara_S.A..pem -> ../../../usr/share/ca-certificates/mozilla/AC_Raíz_Certicámara_S.A..crt
lrwxrwxrwx 1 root root 73 May 21 10:07 ._cfg0000_AC_Raíz_Certicámara_S.A..pem -> ../../../usr/share/ca-certificates/mozilla/AC_Raíz_Certicámara_S.A..crt

dispatch-conf is unable to handle them and just crashes.

Reproducible: Always

Steps to Reproduce:
# echo a > /etc/dummy‽
# echo b > /etc/._cfg0000_dummy‽
# dispatch-conf


Actual Results:  
dispatch-conf crashes with no useful diagnostic:

# dispatch-conf 
Traceback (most recent call last):
  File "/usr/lib/python-exec/python2.7/dispatch-conf", line 511, in <module>
    portage.settings.get('CONFIG_PROTECT', '')))
  File "/usr/lib/python-exec/python2.7/dispatch-conf", line 258, in grind
    confs = [x for x in confs if f(x)]
  File "/usr/lib/python-exec/python2.7/dispatch-conf", line 177, in f
    mrgfail = portage.dispatch_conf.file_archive(archive, conf['current'], conf['new'], mrgconf)
  File "/usr/lib/python2.7/site-packages/portage/dispatch_conf.py", line 266, in file_archive
    "diff -aq '%s' '%s'", curconf, archive)[1]) != 0):
  File "/usr/lib/python2.7/site-packages/portage/dispatch_conf.py", line 117, in __call__
    *args[-2:])
  File "/usr/lib/python2.7/site-packages/portage/dispatch_conf.py", line 91, in diff_mixed
    (file1, link_dest)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 20: ordinal not in range(128)

(I ended up stracing it to see what it was trying to do)

Expected Results:  
dispatch-conf should work as intended with non-ASCII filenames.

Bonus points if it also works with filenames with invalid UTF-8 characters (i.e. if it deals with filenames as byte strings instead of as character strings), though that's less critical. Are non-UTF8 filesystem locales supported in Gentoo? I wonder what app-misc/ca-certificates would use for its filenames in that case.

Workaround for this particular case is to manually move the new symlinks in place:

# cd /etc/ssl/certs
# for i in ._cfg0000_* ; do /bin/mv -f "$i" "${i##._cfg0000_}" ; done

I'm not entirely sure why these were not just installed in-place; the symlinks pointed to the same place anyway. I guess maybe the existing symlinks had their mtime changed or something like that?

Portage 2.2.18 (python 2.7.9-final-0, hardened/linux/x86, gcc-4.8.4, glibc-2.20-r2, 3.13.2-hardened-r3 i686)
=================================================================
System uname: Linux-3.13.2-hardened-r3-i686-QEMU_Virtual_CPU_version_1.7.1-with-gentoo-2.2
KiB Mem:     1023704 total,    170612 free
KiB Swap:    1048572 total,    873416 free
Timestamp of repository gentoo: Mon, 18 May 2015 09:30:01 +0000
sh bash 4.2_p53
ld GNU ld (Gentoo 2.24 p1.4) 2.24
app-shells/bash:          4.2_p53::gentoo
dev-lang/perl:            5.20.2::gentoo
dev-lang/python:          2.7.9-r1::gentoo, 3.3.5-r1::gentoo, 3.4.1::gentoo
dev-util/cmake:           2.8.12.2-r1::gentoo
dev-util/pkgconfig:       0.28-r2::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.13.11::gentoo
sys-apps/sandbox:         2.6-r1::gentoo
sys-devel/autoconf:       2.69::gentoo
sys-devel/automake:       1.13.4::gentoo
sys-devel/binutils:       2.24-r3::gentoo
sys-devel/gcc:            4.8.4::gentoo
sys-devel/gcc-config:     1.7.3::gentoo
sys-devel/libtool:        2.4.6::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 3.18::gentoo (virtual/os-headers)
sys-libs/glibc:           2.20-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="* -@EULA dlj-1.1"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=i686 -fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.5/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -march=i686 -fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-march=i686 -O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=i686 -O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j1"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
USE="acl berkdb bzip2 cli contentcache cracklib crypt ctype curl cxx dovecot-sasl dri dvb exif fam freetype ftp gd gdbm git hardened hash iconv imap ipv6 jpeg libwww loop-aes mailwrapper matroska mhash modules mpeg mysql ncurses nls nptl ogg oidentd openmp pam pax_kernel pcre pdo perl pic png postgres python readline rtsp sasl session sieve simplexml soap sockets spell sqlite ssl stream svg tcpd tiff truetype unicode urandom userlocales vhosts vpx webdav x264 x86 xattr xml xmlreader xmlrpc xmlwriter xsl xtpax zip zlib" ABI_X86="32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx sse sse2 sse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NGINX_MODULES_HTTP="access auth_basic autoindex browser charset echo empty_gif fastcgi geo gzip gzip_static limit_req limit_zone map memcached proxy referer rewrite scgi split_clients ssi upstream_ip_hash userid uwsgi" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="apm ark chips cirrus cyrix dummy fbdev glint i128 i740 intel mach64 mga nsc nv r128 radeon rendition s3 s3virge savage siliconmotion sis sisusb tdfx tga trident tseng v4l vesa via vmware nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

The above synthetic test also triggers the crash on another system with portage-2.2.19.
Comment 1 Hector Martin 2020-06-21 05:55:36 UTC
Can no longer reproduce with python3 based dispatch-conf. Good riddance to python2.