Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 549572 - dev-java/icedtea-7.2.5.5 unnecessarily downloads aarch64 tarball on non-ARM architectures
Summary: dev-java/icedtea-7.2.5.5 unnecessarily downloads aarch64 tarball on non-ARM a...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Andrew John Hughes
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-15 14:49 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2015-05-21 09:10 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
icedtea.patch (icedtea.patch,790 bytes, patch)
2015-05-15 14:50 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2015-05-15 14:49:37 UTC
dev-java/icedtea-7.2.5.5 uses aarch64 tarball only on arm and arm64:

    # Use appropriate HotSpot tarball for architecture
    if { use arm || use arm64; }; then
        hs_tarball="${DISTDIR}/${AARCH64_GENTOO_TARBALL}";
    else
        hs_tarball="${DISTDIR}/${HOTSPOT_GENTOO_TARBALL}";
    fi
...
    --with-hotspot-src-zip="${hs_tarball}" \


But both aarch64 tarball and hotspot tarball are downloaded on all architectures.
(And currently there is no arm or arm64 in KEYWORDS...)
Comment 1 Arfrever Frehtes Taifersar Arahesis 2015-05-15 14:50:43 UTC
Created attachment 403340 [details, diff]
icedtea.patch
Comment 2 James Le Cuirot gentoo-dev 2015-05-15 15:02:29 UTC
Good spot. I shouldn't blindly trust what gnu_andrew gives me. ;) I'll fix this tonight. The cacao and jamvm tarballs are also potentially optional but the logic is too complicated to apply here.

I will hopefully add an ~arm KEYWORD in the near future. No plans for ~arm64 at the moment. :(
Comment 3 Arfrever Frehtes Taifersar Arahesis 2015-05-15 16:35:04 UTC
Also a simplification in code mentioned in comment #0 is possible:
- if { use arm || use arm64; }; then
+ if use arm || use arm64; then
Comment 4 Andrew John Hughes 2015-05-15 19:58:42 UTC
Heh I didn't bother because it's going anyway with 2.6.0. Only added it because 2.5.5 now uses it for arm32 as well as arm64.
Comment 5 James Le Cuirot gentoo-dev 2015-05-16 09:04:48 UTC
Might have to hold off for the moment, bug #549134 means that any changes to icedtea will involve forcing repoman. I could do that but I'd rather not. Closing out that bug is my top priority right now.
Comment 6 James Le Cuirot gentoo-dev 2015-05-21 09:10:48 UTC
Now fixed in the tree.