Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 54947 - wmsystray-0.1.1 (new dockapp package)
Summary: wmsystray-0.1.1 (new dockapp package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Michele Noberasco (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-23 17:14 UTC by Przemyslaw Maciag (RETIRED)
Modified: 2004-07-17 16:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
wmsystray-0.1.1.ebuild (wmsystray-0.1.1.ebuild,687 bytes, text/plain)
2004-06-23 17:15 UTC, Przemyslaw Maciag (RETIRED)
Details
wmsystray-cflags.patch (wmsystray-cflags.patch,1.12 KB, patch)
2004-06-23 17:15 UTC, Przemyslaw Maciag (RETIRED)
Details | Diff
wmsystray.desktop (wmsystray.desktop,208 bytes, text/plain)
2004-06-23 17:16 UTC, Przemyslaw Maciag (RETIRED)
Details
wmsystray-0.1.1.ebuild (wmsystray-0.1.1.ebuild,667 bytes, text/plain)
2004-06-28 09:45 UTC, Przemyslaw Maciag (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Przemyslaw Maciag (RETIRED) gentoo-dev 2004-06-23 17:14:11 UTC
Window Maker dockapp that provides system tray
Comment 1 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-06-23 17:15:18 UTC
Created attachment 34008 [details]
wmsystray-0.1.1.ebuild
Comment 2 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-06-23 17:15:48 UTC
Created attachment 34009 [details, diff]
wmsystray-cflags.patch
Comment 3 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-06-23 17:16:11 UTC
Created attachment 34010 [details]
wmsystray.desktop
Comment 4 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-06-28 09:45:45 UTC
Created attachment 34335 [details]
wmsystray-0.1.1.ebuild

previous ebuild had broken S variable. This one is correct. Sorry :)

Hope you will find it useful.

Regards,
Przemek
Comment 5 Michele Noberasco (RETIRED) gentoo-dev 2004-07-17 04:26:34 UTC
Nice DockApp, and nice ebuild/patch work, only some minor glitches...
Ah, you forgot to install the .desktop file ;-)
In Portage, thanks for the submission!
Comment 6 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-07-17 05:26:45 UTC
Crap........!

Thx and sorry for the desktop file. It was very late at night... ;-)

Nice to hear it's in portage :)))

Regards,
Przemek
Comment 7 Michele Noberasco (RETIRED) gentoo-dev 2004-07-17 06:15:09 UTC
Hehe :-)
I notice you have posted an amount of ebuilds :-)
Guess who is going to have them merged ;-P

They are generally fairly good, yet there are a few (minor) errors that I see you tend to repeat, noticeably:
- if you use epatch you should also "inherit eutils" at the begining of the ebuild
- LICENSE, you have to specify the license version, i.e. "GPL-2" instead of just "GPL"
- first header line should be "# Copyright 1999-2004 Gentoo Foundation"
- trivial stuff like trailing whitespaces and indentation with spaces instead of tabs

Other that that I generally leave your ebuilds as they are :-)
Comment 8 Przemyslaw Maciag (RETIRED) gentoo-dev 2004-07-17 14:34:33 UTC
Great to hear you are going to play with them all! :)

> - if you use epatch you should also "inherit eutils" at the begining of the ebuild
I found that two days ago. Gonna remember!
> - LICENSE, you have to specify the license version, i.e. "GPL-2" instead of just "GPL"
didn't know. Thx!
> - first header line should be "# Copyright 1999-2004 Gentoo Foundation"
Yeah - I know. Every new ebuild I'm creating now have this.
- trivial stuff like trailing whitespaces and indentation with spaces instead of tabs
I like tabs... I'm a happy vim user :))

Regards,
Przemek
Comment 9 Michele Noberasco (RETIRED) gentoo-dev 2004-07-17 16:11:42 UTC
And I am a happy emacs one ;-P