Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 549438 - eutils.eclass: epatch_user: add /etc/portage/package.patches to search list
Summary: eutils.eclass: epatch_user: add /etc/portage/package.patches to search list
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-14 08:23 UTC by charles17
Modified: 2017-08-17 07:49 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description charles17 2015-05-14 08:23:03 UTC
Presently epatch_user uses ${PORTAGE_CONFIGROOT%/}/etc/portage/patches

However the regular file/directory names for package specific information is like:

/etc/portage/package.accept_keywords
/etc/portage/package.unmask
/etc/portage/package.env
/etc/portage/package.use
/etc/portage/package.license
/etc/portage/package.mask

So ${PORTAGE_CONFIGROOT%/} should also use the "package." prefix:

/etc/portage/package.patches
Comment 1 SpanKY gentoo-dev 2015-05-14 16:38:21 UTC
we can add support for package.patches, but i don't see us dropping the current path

the current path also has an argument for it in the sense that package.xxx is kind of reserved by portage (although you could say that all of /etc/portage is reserved by portage)
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-05-14 16:48:33 UTC
I strongly object to adding any new /etc/portage path in eutils.
Comment 3 SpanKY gentoo-dev 2015-08-14 08:46:18 UTC
(In reply to Michał Górny from comment #2)

you didn't provide any reasoning at all

portage: are there any plans cooking to utilize package.patches ?  or do we prefer to keep that namespace clear ?
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-08-14 09:36:54 UTC
(In reply to SpanKY from comment #3)
> (In reply to Michał Górny from comment #2)
> 
> you didn't provide any reasoning at all

The reasoning: /etc/portage is for paths utilized by *Portage*, the package manager, not random functions from random eclasses. Whole /etc/portage is reserved for Portage, without any exceptions.
Comment 5 Zac Medico gentoo-dev 2015-08-15 02:22:20 UTC
(In reply to SpanKY from comment #3)
> portage: are there any plans cooking to utilize package.patches ?  or do we
> prefer to keep that namespace clear ?

Well, eappy_user is already included in EAPI 6, and it uses /etc/portage/patches just like epatch_user does:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=f188c989317a58ffc54cc0c022c728c100de9000

As EAPI 5 and earlier gradually die off, so will epatch_user.

If we'd like portage to use /etc/portage/package.patches for eapply_user, then we should make that decision before EAPI 6 is finalized.